This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix: parsing zero value timestamp#1355
Merged
alvarowolfx merged 2 commits intogoogleapis:mainfrom Apr 9, 2024
Merged
Conversation
product-auto-label
Bot
added
size: s
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
leahecole
approved these changes
Apr 9, 2024
4 tasks
This was referenced Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreciseDateclass fails when instantiated with zero value ( number0orBigInt(0)). UsingPreciseDate.parseFull+preciseDateInstance.setFulltimemanually withBigIntskips the code paths that doesn't check for zero.Reference:
Fixes #1353 🦕
Supersedes #1354