Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: PreciseDate constructor when value is timestamp 1970-01-01 00:00:00 UTC#1354

Closed
guisalim wants to merge 1 commit intogoogleapis:mainfrom
guisalim:fix-zero-value-for-timestamp-column
Closed

fix: PreciseDate constructor when value is timestamp 1970-01-01 00:00:00 UTC#1354
guisalim wants to merge 1 commit intogoogleapis:mainfrom
guisalim:fix-zero-value-for-timestamp-column

Conversation

@guisalim
Copy link
Copy Markdown

@guisalim guisalim commented Apr 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1353 🦕

@guisalim guisalim requested review from a team and shollyman April 8, 2024 17:37
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Apr 8, 2024
@guisalim
Copy link
Copy Markdown
Author

guisalim commented Apr 8, 2024

CLA already signed

@alvarowolfx
Copy link
Copy Markdown
Contributor

superseeded by #1355

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Library cannot parse timestamp value "0" - Cannot convert a BigInt value to a number as PreciseDate

2 participants