Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: add support for RANGE type#1352

Merged
alvarowolfx merged 9 commits intogoogleapis:mainfrom
alvarowolfx:feat-range-support
Apr 22, 2024
Merged

feat: add support for RANGE type#1352
alvarowolfx merged 9 commits intogoogleapis:mainfrom
alvarowolfx:feat-range-support

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx commented Apr 5, 2024

Fixes #1344 🦕

BEGIN_COMMIT_OVERRIDE
chore: remove range support
END_COMMIT_OVERRIDE

@alvarowolfx alvarowolfx requested review from a team and nayaknishant April 5, 2024 20:06
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Apr 5, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 8, 2024
@alvarowolfx alvarowolfx requested review from Linchin, feywind and shollyman and removed request for nayaknishant April 9, 2024 18:08
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 10, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 10, 2024
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but one question about what string formats we support.

Comment thread src/bigquery.ts
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 16, 2024
Comment thread src/bigquery.ts Outdated
Comment thread src/bigquery.ts
Comment thread src/bigquery.ts Outdated
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@Linchin Linchin self-requested a review April 18, 2024 18:22
Copy link
Copy Markdown

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the replies, I think the PR is already approved, but I'll just approve again in case you're waiting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for RANGE type

3 participants