This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix: set projectId in jobs emitted by load streams#1346
Merged
alvarowolfx merged 2 commits intogoogleapis:mainfrom Mar 27, 2024
Merged
fix: set projectId in jobs emitted by load streams#1346alvarowolfx merged 2 commits intogoogleapis:mainfrom
alvarowolfx merged 2 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
Bot
added
size: xs
alvarowolfx
approved these changes
Mar 27, 2024
Contributor
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
Thanks for the contribution @onekilobit-supersocial. Changes looks good to me. I'll wait for CI test to run and merge it.
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
alvarowolfx
added
kokoro:force-run
gcf-owl-bot
Bot
removed
the
owlbot:run
This was referenced Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitly sets the project ID in jobs returned by loading operations that are stream-based (e.g.
Table.load(filePath)orTable.createWriteStream()), which fixes support for project IDs specified at the dataset level.Fixes #1345 🦕