This repository was archived by the owner on Feb 7, 2026. It is now read-only.
feat: switch timestamp representation to int64 usec#1332
Merged
alvarowolfx merged 6 commits intogoogleapis:mainfrom Feb 21, 2024
Merged
feat: switch timestamp representation to int64 usec#1332alvarowolfx merged 6 commits intogoogleapis:mainfrom
alvarowolfx merged 6 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: m
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
shollyman
approved these changes
Feb 15, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
one question on the conversion codepath, but the the callsites look correct given we don't yet do jobs.query RPCs.
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
shollyman
reviewed
Feb 20, 2024
shollyman
approved these changes
Feb 20, 2024
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This was referenced Mar 5, 2024
alvarowolfx
added a commit
that referenced
this pull request
Mar 12, 2024
This reverts commit fb10f03.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest Discovery document updates, we can now correctly propagate the options for controlling timestamp representation. This PR forces all usages to lossless representations. Similarly to PR googleapis/google-cloud-go#9368
Fixes internal b/323945838