This repository was archived by the owner on Feb 7, 2026. It is now read-only.
fix: prefer usage of projectId from the Dataset#1326
Merged
alvarowolfx merged 3 commits intogoogleapis:mainfrom Jan 24, 2024
Merged
fix: prefer usage of projectId from the Dataset#1326alvarowolfx merged 3 commits intogoogleapis:mainfrom
alvarowolfx merged 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: m
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
shollyman
reviewed
Jan 23, 2024
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
Thanks for putting this together!
shollyman
approved these changes
Jan 23, 2024
This was referenced Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the internal
projectIdattribute on theDatasetclass required and use it instead of the one set on theClient. This way allDatasetsby default uses the ClientprojectId, but it can be override manually by the user if needed (which was enabled on PR #1230). This fixes some issues with users wanting to make operations on different projects with the same client.Fixes #1133 #1265 🦕