This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
Bot
added
the
api: bigquery
…js-bigquery into feat_sample_test_retries merging changes from remote
product-auto-label
Bot
added
size: s
loferris
added
type: feature request
gcf-owl-bot
Bot
removed
the
owlbot:run
loferris
added
the
priority: p2
alvarowolfx
suggested changes
Oct 25, 2023
Contributor
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
Added a comment on how to make retries more granular and efficient.
|
|
||
| describe('Authorized View Tutorial', () => { | ||
| describe('Authorized View Tutorial', function () { | ||
| this.retries(3); |
Contributor
There was a problem hiding this comment.
I think doing this way, it will retry the whole describe section, which can be quite expensive to re run. I ran some tests here and seems like we can retry on a per spec basis.
describe('Authorized View Tutorial', () => { // Back to arrow function
beforeEach(function(){
console.log("this:", this.currentTest.title)
this.currentTest.retries(2); // will try 3 times - n+1
})
Then I changed one of the tests to fail, to check for the retry behavior:
it('should query stackoverflow', async () => {
const output = execSync('node queryStackOverflow.js');
assert.match(output, /Query Results:/);
assert.match(output, /views/);
assert.match(0,1)
}); // Force failure
added 2 commits
October 25, 2023 13:44
product-auto-label
Bot
added
size: m
alvarowolfx
approved these changes
Oct 30, 2023
added 2 commits
November 1, 2023 19:55
loferris
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
This was referenced Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1299 🦕