Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: updated types from API discovery doc#1284

Merged
loferris merged 2 commits intomainfrom
fix_type_gen
Sep 28, 2023
Merged

fix: updated types from API discovery doc#1284
loferris merged 2 commits intomainfrom
fix_type_gen

Conversation

@loferris
Copy link
Copy Markdown
Contributor

@loferris loferris commented Sep 28, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@loferris loferris requested review from a team and chalmerlowe September 28, 2023 00:31
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Sep 28, 2023
@loferris loferris merged commit 1d8a2b7 into main Sep 28, 2023
@loferris loferris deleted the fix_type_gen branch September 28, 2023 17:57
@release-please release-please Bot mentioned this pull request Sep 28, 2023
Merged
This was referenced Oct 3, 2023
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

1 more reviewer

@alvarowolfx alvarowolfx alvarowolfx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@loferris @alvarowolfx