Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

fix: updating type for test blocking dependency updates#1282

Merged
gcf-merge-on-green[bot] merged 1 commit intomainfrom
chore_actions_v4
Sep 27, 2023
Merged

fix: updating type for test blocking dependency updates#1282
gcf-merge-on-green[bot] merged 1 commit intomainfrom
chore_actions_v4

Conversation

@loferris
Copy link
Copy Markdown
Contributor

@loferris loferris commented Sep 27, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1269 🦕
Fixes #1277 🦕

@loferris loferris requested review from a team and jainsahab September 27, 2023 21:33
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Sep 27, 2023
@loferris loferris changed the title updating type for test fix: updating type for test Sep 27, 2023
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Sep 27, 2023
@conventional-commit-lint-gcf
Copy link
Copy Markdown

conventional-commit-lint-gcf Bot commented Sep 27, 2023 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@loferris loferris changed the title fix: updating type for test fix: updating type for test blocking dependency updates Sep 27, 2023
@loferris loferris self-assigned this Sep 27, 2023
@loferris loferris added the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2023
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 1dbe0fe into main Sep 27, 2023
@gcf-merge-on-green gcf-merge-on-green Bot deleted the chore_actions_v4 branch September 27, 2023 22:20
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2023
@release-please release-please Bot mentioned this pull request Sep 27, 2023
Merged
This was referenced Oct 3, 2023
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jainsahab jainsahab Awaiting requested review from jainsahab

1 more reviewer

@Linchin Linchin Linchin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@loferris loferris

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tables Views: should update a view failed

2 participants

@loferris @Linchin