This repository was archived by the owner on Feb 7, 2026. It is now read-only.
feat: re-exporting types for google-common#1271
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
Bot
added
size: xs
added 3 commits
September 12, 2023 18:42
…bigquery into feat_api_error_export reconciling local
alvarowolfx
approved these changes
Sep 13, 2023
Contributor
alvarowolfx
left a comment
alvarowolfx
left a comment
There was a problem hiding this comment.
Make sense to me. To we know if other libraries have that same kind of pattern ?
Contributor
Author
I'm pretty sure the other languages do not, but it is a pattern in TypeScript libraries in general. |
This was referenced Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1268 🦕
This PR introduces a re-exporting pattern to the library that allows for users to import
google-commonalong withbigquery. This option ensures that users' version ofgoogle-commonis the same as the one used in the BigQuery library. This is also a way to gauge the value of re-exporting dependencies in the library.