Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: support create/list datasets on a different project#1230

Merged
alvarowolfx merged 4 commits intogoogleapis:mainfrom
alvarowolfx:dataset-another-project
Aug 1, 2023
Merged

feat: support create/list datasets on a different project#1230
alvarowolfx merged 4 commits intogoogleapis:mainfrom
alvarowolfx:dataset-another-project

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

Override projectId used by the request method when projectId is informed when creating and referencing a dataset.

Fixes #1227 🦕

@alvarowolfx alvarowolfx requested review from a team and chalmerlowe July 27, 2023 18:18
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jul 27, 2023
@alvarowolfx alvarowolfx requested a review from shollyman July 27, 2023 18:18
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to do similar in followup PRs for other resource types beyond datasets?

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 31, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2023
@alvarowolfx alvarowolfx merged commit 86c63fb into googleapis:main Aug 1, 2023
@atrbgithub
Copy link
Copy Markdown

Thanks for this @alvarowolfx 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does createDataset support the supplying of a projectId?

3 participants