Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

chore: update types from Discovery#1225

Merged
alvarowolfx merged 2 commits intogoogleapis:mainfrom
alvarowolfx:chore-sync-discovery-types
Jul 17, 2023
Merged

chore: update types from Discovery#1225
alvarowolfx merged 2 commits intogoogleapis:mainfrom
alvarowolfx:chore-sync-discovery-types

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx commented Jul 13, 2023

Sync discovery types and handle some internal issues related to adding new fields to Node SDK:

  • Default Value Expression - b/243165219
  • Sessions in Load Jobs - b/268632415
  • Reference File Schema for load/federated queries - b/246810696
  • Remote Function Options - b/249154342
  • searchStatistics - b/290679162

@alvarowolfx alvarowolfx requested review from a team and Neenu1995 July 13, 2023 17:28
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jul 13, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2023
@alvarowolfx alvarowolfx requested a review from shollyman July 13, 2023 19:23
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding some details to the PR description about how the generator was invoked?

@alvarowolfx
Copy link
Copy Markdown
Contributor Author

Mind adding some details to the PR description about how the generator was invoked?

there is a script on the package.json file for that.
npm run types

This uses an external dependency to generate type.d.ts files based on the discovery docs.
https://github.com/callmehiphop/discovery-tsd

@alvarowolfx alvarowolfx merged commit 51fc8c3 into googleapis:main Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants