This repository was archived by the owner on Feb 7, 2026. It is now read-only.
test: parallel tests can error on already deleted dataset#1214
Merged
alvarowolfx merged 4 commits intogoogleapis:mainfrom Jun 2, 2023
Merged
test: parallel tests can error on already deleted dataset#1214alvarowolfx merged 4 commits intogoogleapis:mainfrom
alvarowolfx merged 4 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: s
alvarowolfx
added
kokoro:run
gcf-owl-bot
Bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
alvarowolfx
added
kokoro:run
gcf-owl-bot
Bot
removed
the
owlbot:run
product-auto-label
Bot
added
the
api: bigquery
alvarowolfx
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:run
ruyadorno
suggested changes
Jun 2, 2023
There was a problem hiding this comment.
Instead of turning the try/catch expression into a catch-all block, it's better to leave the previous try/catch block as-is and add a new one that covers specifically the metadata retrieval which seems to be failing, e.g:
+ try {
const [metadata] = await dataset.getMetadata();
+ } catch (e) {
+ console.log(`failed to retrieve dataset(${dataset.id})`);
+ console.log(e);
+. return;
+ }This way, the intention and the unexpected nature of these failures are better documented for future readers.
This comment was marked as outdated.
This comment was marked as outdated.
ruyadorno
reviewed
Jun 2, 2023
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
ruyadorno
approved these changes
Jun 2, 2023
alvarowolfx
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
samples-testfail sometimes when datasets were already deleted by another process ( in this case system tests ) running in parallel.Example:
build #703