Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

chore(deps): remove readable-stream#1213

Merged
alvarowolfx merged 5 commits intogoogleapis:mainfrom
alvarowolfx:deps-remove-readable-stream
Jun 2, 2023
Merged

chore(deps): remove readable-stream#1213
alvarowolfx merged 5 commits intogoogleapis:mainfrom
alvarowolfx:deps-remove-readable-stream

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

@alvarowolfx alvarowolfx commented Jun 1, 2023

Remove readable-stream as was being used only on system-tests and it can actually be imported from the native streams package.

Fixes #1200 🦕

@alvarowolfx alvarowolfx requested review from a team and GaoleMeng June 1, 2023 18:03
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Jun 1, 2023
@alvarowolfx alvarowolfx mentioned this pull request Jun 1, 2023
Closed
@alvarowolfx alvarowolfx added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 1, 2023
@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 1, 2023
@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@alvarowolfx alvarowolfx requested a review from steffnay June 1, 2023 19:03
ruyadorno
ruyadorno reviewed Jun 1, 2023
View reviewed changes
Comment thread samples/test/datasets.test.js
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jun 1, 2023
@alvarowolfx alvarowolfx added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 1, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@alvarowolfx alvarowolfx added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2023
@alvarowolfx alvarowolfx added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 2, 2023
@alvarowolfx alvarowolfx merged commit 4510520 into googleapis:main Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GaoleMeng GaoleMeng Awaiting requested review from GaoleMeng

@steffnay steffnay Awaiting requested review from steffnay

1 more reviewer

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consideration of removing an unnecessary dependency.

3 participants

@alvarowolfx @ruyadorno @yoshi-kokoro