Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

types: add file[] to load() and createLoadJob() as valid source parameter#1105

Merged
steffnay merged 2 commits intogoogleapis:mainfrom
simllll:patch-1
Jul 11, 2022
Merged

types: add file[] to load() and createLoadJob() as valid source parameter#1105
steffnay merged 2 commits intogoogleapis:mainfrom
simllll:patch-1

Conversation

@simllll
Copy link
Copy Markdown
Contributor

@simllll simllll commented Apr 20, 2022 •
edited
Loading

possbile fixes #1104

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@simllll simllll requested review from a team and stephaniewang526 April 20, 2022 18:18
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Apr 20, 2022
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Apr 20, 2022
@simllll simllll changed the title add file[] to load() and createLoadJob() as valid source parameter types: add file[] to load() and createLoadJob() as valid source parameter Apr 20, 2022
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2022
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 5, 2022
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2022
@steffnay steffnay added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2022
@steffnay steffnay merged commit 20f04c2 into googleapis:main Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

1 more reviewer

@steffnay steffnay steffnay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@steffnay steffnay

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

typescript definition for load() is missing File[]

3 participants

@simllll @steffnay @yoshi-kokoro