This repository was archived by the owner on Feb 7, 2026. It is now read-only.
chore: update dtsd version and discovery types#1098
Merged
steffnay merged 1 commit intogoogleapis:mainfrom Apr 14, 2022
Merged
Conversation
product-auto-label
Bot
added
size: l
steffnay
added
the
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
feywind
approved these changes
Apr 13, 2022
Contributor
feywind
left a comment
feywind
left a comment
There was a problem hiding this comment.
Just a few suggestions!
Also it seems like the check annotation warnings are piling up, I don't think you should try to fix them in this PR, but maybe it's something to consider later if there's a cleanup pass.
|
|
||
| /** | ||
| * The type of a variable, e.g., a function argument. Examples: INT64: {type_kind="INT64"} ARRAY: {type_kind="ARRAY", array_element_type="STRING"} STRUCT>: {type_kind="STRUCT", struct_type={fields=[ {name="x", type={type_kind="STRING"}}, {name="y", type={type_kind="ARRAY", array_element_type="DATE"}} ]}} | ||
| * The data type of a variable such as a function argument. Examples include: * INT64: `{"typeKind": "INT64"}` * ARRAY: { "typeKind": "ARRAY", "arrayElementType": {"typeKind": "STRING"} } * STRUCT>: { "typeKind": "STRUCT", "structType": { "fields": [ { "name": "x", "type": {"typeKind: "STRING"} }, { "name": "y", "type": { "typeKind": "ARRAY", "arrayElementType": {"typekind": "DATE"} } } ] } } |
Contributor
There was a problem hiding this comment.
Seems like something happened to the formatting here? It looks like it was meant to be multi-line.
shollyman
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the version of discovery-tsd and regenerates types from the Discovery Doc.
Fixes #1089 🦕