Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: add cross-project support#1079

Merged
steffnay merged 5 commits intogoogleapis:mainfrom
steffnay:projectIdOverride
Feb 10, 2022
Merged

feat: add cross-project support#1079
steffnay merged 5 commits intogoogleapis:mainfrom
steffnay:projectIdOverride

Conversation

@steffnay
Copy link
Copy Markdown
Contributor

@steffnay steffnay commented Feb 6, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1030 #527 🦕

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Feb 6, 2022
@steffnay steffnay marked this pull request as ready for review February 6, 2022 20:16
@steffnay steffnay requested review from a team and shollyman February 6, 2022 20:16
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2022
@satrox28
Copy link
Copy Markdown

satrox28 commented Feb 8, 2022

Hi @shollyman,

Can you able to check and approve it. We are eagerly looking for this feature from past few months.

Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need more disambiguation for expressing fully qualified references for non-dataset resources like jobs?

Copy link
Copy Markdown
Contributor

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satrox28
Copy link
Copy Markdown

Can it be merged, any pending?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cross Project Support

4 participants