Skip to content
This repository was archived by the owner on Feb 7, 2026. It is now read-only.

feat: Add jobs.delete #1023

Merged
steffnay merged 25 commits intogoogleapis:mainfrom
steffnay:add-jobs-delete
Jan 10, 2022
Merged

feat: Add jobs.delete #1023
steffnay merged 25 commits intogoogleapis:mainfrom
steffnay:add-jobs-delete

Conversation

@steffnay
Copy link
Copy Markdown
Contributor

@steffnay steffnay commented Oct 8, 2021 •
edited
Loading

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1010 🦕

@steffnay steffnay requested review from a team and loferris October 8, 2021 21:28
@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the googleapis/nodejs-bigquery API. label Oct 8, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@steffnay steffnay added owlbot:ignore instruct owl-bot to ignore a PR owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 8, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@steffnay steffnay added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Oct 8, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 8, 2021
@steffnay steffnay assigned steffnay and unassigned stephenplusplus Oct 8, 2021
@steffnay steffnay changed the title feat: Add jobs.delete feat: Add jobs.delete and update to latest discovery types Oct 10, 2021
JustinBeckwith
JustinBeckwith previously requested changes Oct 11, 2021
View reviewed changes
Comment thread src/job.ts Outdated
Comment thread src/job.ts Outdated
JustinBeckwith
JustinBeckwith reviewed Nov 3, 2021
View reviewed changes
Comment thread src/job.ts Outdated
Comment thread src/job.ts Outdated
@steffnay
Copy link
Copy Markdown
Contributor Author

steffnay commented Nov 15, 2021 •
edited
Loading

@JustinBeckwith I realized I needed to refactor, so the type issues are no longer a thing.

@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2021
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 8, 2021
@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2021
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 15, 2021
bcoe
bcoe reviewed Dec 15, 2021
View reviewed changes
Comment thread system-test/bigquery.ts
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 3, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 3, 2022
@steffnay steffnay added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@steffnay steffnay merged commit 12f7771 into googleapis:main Jan 10, 2022
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jan 10, 2022
@release-please
chore: release 5.10.0 (#1059)
5d5facd 
🤖 I have created a release \*beep\* \*boop\*
---
## [5.10.0](https://www.github.com/googleapis/nodejs-bigquery/compare/v5.9.3...v5.10.0) (2022-01-10)


### Features

* Add jobs.delete and update to latest discovery types ([#1023](https://www.github.com/googleapis/nodejs-bigquery/issues/1023)) ([12f7771](https://www.github.com/googleapis/nodejs-bigquery/commit/12f77710accfca8c512d021a1c75a732c6c666f7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@steffnay steffnay changed the title feat: Add jobs.delete and update to latest discovery types feat: Add jobs.delete Jan 18, 2022
@release-please release-please Bot mentioned this pull request May 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferris loferris Awaiting requested review from loferris

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

2 more reviewers

@fhinkel fhinkel fhinkel left review comments

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@steffnay steffnay

Labels

api: bigquery Issues related to the googleapis/nodejs-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery - support jobs.delete

5 participants

@steffnay @fhinkel @bcoe @JustinBeckwith @stephenplusplus