fix: should not override queryParameters if params not informed (#1359)

alvarowolfx · web-flow · commit 2b66d1e5d57d · 2024-04-26T11:56:01.000-04:00
diff --git a/src/bigquery.ts b/src/bigquery.ts
@@ -1469,13 +1469,15 @@ export class BigQuery extends Service {
       delete query.destination;
     }
 
-    const {parameterMode, params} = this.buildQueryParams_(
-      query.params,
-      query.types
-    );
-    query.parameterMode = parameterMode;
-    query.queryParameters = params;
-    delete query.params;
+    if (query.params) {
+      const {parameterMode, params} = this.buildQueryParams_(
+        query.params,
+        query.types
+      );
+      query.parameterMode = parameterMode;
+      query.queryParameters = params;
+      delete query.params;
+    }
 
     const reqOpts: JobOptions = {};
     reqOpts.configuration = {
diff --git a/test/bigquery.ts b/test/bigquery.ts
@@ -2343,6 +2343,26 @@ describe('BigQuery', () => {
         );
       });
 
+      it('should not modify queryParameters if params is not informed', done => {
+        bq.createJob = (reqOpts: JobOptions) => {
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
+          assert.strictEqual((reqOpts as any).params, undefined);
+          assert.deepStrictEqual(
+            reqOpts.configuration?.query?.queryParameters,
+            NAMED_PARAMS
+          );
+          done();
+        };
+
+        bq.createQueryJob(
+          {
+            query: QUERY_STRING,
+            queryParameters: NAMED_PARAMS,
+          },
+          assert.ifError
+        );
+      });
+
       describe('named', () => {
         it('should set the correct parameter mode', done => {
           bq.createJob = (reqOpts: JobOptions) => {
