Skip to content
This repository was archived by the owner on Jul 13, 2023. It is now read-only.

[Asset] Add quickstart sample code for BatchGetAsstesHistory.#59

Merged
JustinBeckwith merged 9 commits intogoogleapis:masterfrom
peter-zheng-g:master
Nov 27, 2018
Merged

[Asset] Add quickstart sample code for BatchGetAsstesHistory.#59
JustinBeckwith merged 9 commits intogoogleapis:masterfrom
peter-zheng-g:master

Conversation

@peter-zheng-g
Copy link
Copy Markdown
Contributor

@peter-zheng-g peter-zheng-g commented Nov 26, 2018

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2018
JustinBeckwith
JustinBeckwith reviewed Nov 26, 2018
View reviewed changes
Comment thread samples/system-test/quickstart.test.js Outdated
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 26, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 26, 2018
@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 26, 2018

Looks like ES6 style format doesn't work with the env...

@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Nov 26, 2018

I'm not sure what you mean? It works great :) What specifically isn't working for you?

@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 26, 2018

Maybe it's my dev env config issue... I tried running the test on my local machine with the formatted string output to console, and see the string was not correctly formatted.

@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Nov 26, 2018

Can you run 'npm run fix'?

@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 26, 2018

Edited file .eslintrc.yml to allow dependency on unpublished package nodejs-repo-tools.

JustinBeckwith
JustinBeckwith reviewed Nov 26, 2018
View reviewed changes
Comment thread .eslintrc.yml Outdated
@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 27, 2018

Can you run 'npm run fix'?

Lint is not complaining now.

JustinBeckwith
JustinBeckwith suggested changes Nov 27, 2018
View reviewed changes
Comment thread samples/.eslintrc.yml Outdated
Comment thread samples/.eslintrc.yml Outdated
Comment thread samples/system-test/quickstart.test.js Outdated
Comment thread samples/system-test/quickstart.test.js Outdated
@JustinBeckwith
Copy link
Copy Markdown
Contributor

JustinBeckwith commented Nov 27, 2018

Can you share the output of npm run fix after fixing the stuff above?

@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 27, 2018 •
edited
Loading

Can you share the output of npm run fix after fixing the stuff above?

$ npm i && npm run fix
npm WARN [email protected] requires a peer of acorn@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

audited 6104 packages in 3.78s
found 0 vulnerabilities

@google-cloud/[email protected] fix ~/github/nodejs-asset/samples
eslint --fix '*.js'

JustinBeckwith
JustinBeckwith reviewed Nov 27, 2018
View reviewed changes
Comment thread samples/package.json Outdated
@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 27, 2018

$ npm run fix

@google-cloud/[email protected] fix ~/github/nodejs-asset
eslint --fix '**/*.js'

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2018
@JustinBeckwith JustinBeckwith merged commit bb63e6c into googleapis:master Nov 27, 2018
@peter-zheng-g
Copy link
Copy Markdown
Contributor Author

peter-zheng-g commented Nov 28, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peter-zheng-g @JustinBeckwith @googlebot @kokoro-team