Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

feat: remove unsupported accelerator types feat: add aiplatform API Vizier service#92

Merged
telpirion merged 2 commits intomasterfrom
autosynth-googleapis
Apr 2, 2021
Merged

feat: remove unsupported accelerator types feat: add aiplatform API Vizier service#92
telpirion merged 2 commits intomasterfrom
autosynth-googleapis

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

@yoshi-automation yoshi-automation commented Mar 20, 2021

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/d3b8aa00-c71a-4bae-b7eb-c13ba1aac834/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 363921711
Source-Link: googleapis/googleapis@4ea5a27

@yoshi-automation
feat!: BREAKING CHANGE: remove unsupported accelerator types feat: ad…
e555c41 
…d aiplatform API Vizier service

Committer: @dizcology
PiperOrigin-RevId: 363921711

Source-Author: Google APIs <[email protected]>
Source-Date: Fri Mar 19 10:37:18 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 4ea5a2764a08f86676d0e853dbb01c4e9868a22b
Source-Link: googleapis/googleapis@4ea5a27
@yoshi-automation yoshi-automation requested review from a team March 20, 2021 11:00
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 20, 2021 •
edited
Loading

Codecov Report

Merging #92 (bd99cc2) into master (c5218d7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   98.61%   98.65%   +0.03%     
==========================================
  Files          24       25       +1     
  Lines       41669    45347    +3678     
  Branches     1072     1186     +114     
==========================================
+ Hits        41091    44735    +3644     
- Misses        562      595      +33     
- Partials       16       17       +1
Impacted Files Coverage Δ
src/v1beta1/vizier_service_client.ts 98.96% <ø> (ø)
src/v1beta1/dataset_service_client.ts 99.16% <100.00%> (+0.01%) ⬆️
src/v1beta1/endpoint_service_client.ts 99.02% <100.00%> (+0.02%) ⬆️
src/v1beta1/index.ts 100.00% <100.00%> (ø)
src/v1beta1/job_service_client.ts 99.21% <100.00%> (+<0.01%) ⬆️
src/v1beta1/migration_service_client.ts 98.71% <100.00%> (+0.03%) ⬆️
src/v1beta1/model_service_client.ts 99.11% <100.00%> (+0.01%) ⬆️
src/v1beta1/pipeline_service_client.ts 98.81% <100.00%> (+0.02%) ⬆️
src/v1beta1/prediction_service_client.ts 98.43% <100.00%> (+0.05%) ⬆️
src/v1beta1/specialist_pool_service_client.ts 98.93% <100.00%> (+0.02%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5218d7...bd99cc2. Read the comment docs.

@telpirion telpirion added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 22, 2021
@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Mar 23, 2021

@telpirion @bcoe, I don't think this should be a breaking change. If it must be, perhaps we should wait until we upgrade the Node engine so as to have only one breaking change for the year. WDYT?

@bcoe
Copy link
Copy Markdown

bcoe commented Mar 31, 2021

@sofisl @telpirion if we're only touching the v1beta1 surface, I think it's fine to remove the breaking change markers when landing.

@sofisl sofisl changed the title feat!: BREAKING CHANGE: remove unsupported accelerator types feat: add aiplatform API Vizier service feat: remove unsupported accelerator types feat: add aiplatform API Vizier service Apr 1, 2021
@sofisl
Copy link
Copy Markdown
Contributor

sofisl commented Apr 1, 2021

@bcoe @telpirion, I think this is ready to merge :)

@telpirion telpirion merged commit 23f184d into master Apr 2, 2021
@telpirion telpirion deleted the autosynth-googleapis branch April 2, 2021 17:13
@release-please release-please Bot mentioned this pull request Apr 2, 2021
Closed
@sofisl sofisl mentioned this pull request Apr 5, 2021
Closed
@release-please release-please Bot mentioned this pull request Apr 21, 2021
Closed
@release-please release-please Bot mentioned this pull request May 11, 2021
Merged
@release-please release-please Bot mentioned this pull request May 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@telpirion telpirion telpirion approved these changes

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. context: full

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @sofisl @bcoe @telpirion