Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

feat(samples): add feature values apis samples#341

Merged
junkourata merged 15 commits intogoogleapis:mainfrom
suryaguthikonda:feature-values-apis
Aug 4, 2022
Merged

feat(samples): add feature values apis samples#341
junkourata merged 15 commits intogoogleapis:mainfrom
suryaguthikonda:feature-values-apis

Conversation

@suryaguthikonda
Copy link
Copy Markdown
Contributor

@suryaguthikonda suryaguthikonda commented Jun 28, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #313

@suryaguthikonda suryaguthikonda requested review from a team June 28, 2022 07:09
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jun 28, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. samples Issues that are directly related to samples. labels Jun 28, 2022
@junkourata junkourata added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2022
@junkourata junkourata self-requested a review June 30, 2022 07:04
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

gcf-merge-on-green Bot commented Jun 30, 2022

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 30, 2022
@junkourata junkourata added kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@junkourata junkourata requested a review from dizcology July 8, 2022 00:40
@junkourata junkourata added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 28, 2022
@generated-files-bot
Copy link
Copy Markdown

generated-files-bot Bot commented Jul 28, 2022

Warning: This pull request is touching the following templated files:

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022
@junkourata junkourata added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 29, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 3, 2022
@junkourata junkourata added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 3, 2022
@junkourata junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@junkourata junkourata added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 3, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 3, 2022
@junkourata junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2022
@junkourata junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2022
@junkourata junkourata merged commit 4cef015 into googleapis:main Aug 4, 2022
@release-please release-please Bot mentioned this pull request Aug 4, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@dizcology dizcology dizcology approved these changes

@junkourata junkourata junkourata approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add sample snippets for Vertex Feature Store

4 participants

@suryaguthikonda @dizcology @junkourata @yoshi-kokoro