feat: enable per source level flags for sql commenter#3387
Closed
AjmeraParth132 wants to merge 2 commits into
Closed
feat: enable per source level flags for sql commenter#3387AjmeraParth132 wants to merge 2 commits into
AjmeraParth132 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a per-source sqlCommenter configuration option across multiple database sources (AlloyDB, Cloud SQL MySQL, Cloud SQL Postgres, MySQL, Postgres, and SQLite), allowing users to override the global --sql-commenter flag. The sqlcommenter.AppendComment function was updated to accept this override, and corresponding unit tests were added to verify the priority of the per-source setting over the global flag. Additionally, SQL commenter support was removed from MSSQL sources, and documentation was updated to reflect the new configuration option. No review comments were provided, so there is no feedback to address.
anubhav756
force-pushed
the
feat/sql-commenter-flags
branch
from
6b5d621 to
26a4826
Compare
Contributor
|
/gcbrun |
6 tasks
anubhav756
approved these changes
Jun 16, 2026
anubhav756
reviewed
Jun 16, 2026
anubhav756
left a comment
anubhav756
left a comment
Contributor
There was a problem hiding this comment.
Also, it would be great to have integration tests for SQLite.
|
|
||
| func (s *Source) RunSQL(ctx context.Context, statement string, params []any) (any, error) { | ||
| statement = sqlcommenter.AppendComment(ctx, statement, SourceType) | ||
| statement = sqlcommenter.AppendComment(ctx, statement, SourceType, s.SQLCommenter) |
Contributor
There was a problem hiding this comment.
nit: This function actually prepends, so maybe rename?
anubhav756
requested changes
Jun 16, 2026
anubhav756
left a comment
anubhav756
left a comment
Contributor
There was a problem hiding this comment.
Method name change and test coverage as requested in the comments.
anubhav756
force-pushed
the
feat/sql-commenter-flags
branch
from
26a4826 to
46094a6
Compare
Contributor
|
/gcbrun |
anubhav756
added
the
priority: p1
6 tasks
Contributor
|
Closing this PR in favour of #3465 |
averikitsch
pushed a commit
that referenced
this pull request
Jun 17, 2026
## Description Documentation update for added SQLCommenter support, and `telemetry_attributes` exposure for client SDKs > [!NOTE] > This PR supercedes the previous PR #3281 to update that with the latest changes from #3387. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #3061 --------- Co-authored-by: Parth Ajmera <[email protected]>
anubhav756
added a commit
that referenced
this pull request
Jun 18, 2026
## Description > [!NOTE] > This PR builds upon #3387 by patching a function name [issue](#3387 (comment)). A separate, follow-up PR will be created to add unit and integration tests for SQLCommenter. As an extension to SQLCommenter functionality, we are introducing a new configuration flag, `sqlCommenter`, that can be specified per source in tools.yaml to enable SQL commenting at the source level. This source-specific flag takes precedence over the global `--sql-commenter` flag when configured. If `sqlCommenter` is not explicitly set for a source, the global `--sql-commenter` flag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users. > [!IMPORTANT] > We are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #3061 --------- Co-authored-by: Parth Ajmera <[email protected]>
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 18, 2026
## Description > [!NOTE] > This PR builds upon #3387 by patching a function name [issue](#3387 (comment)). A separate, follow-up PR will be created to add unit and integration tests for SQLCommenter. As an extension to SQLCommenter functionality, we are introducing a new configuration flag, `sqlCommenter`, that can be specified per source in tools.yaml to enable SQL commenting at the source level. This source-specific flag takes precedence over the global `--sql-commenter` flag when configured. If `sqlCommenter` is not explicitly set for a source, the global `--sql-commenter` flag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users. > [!IMPORTANT] > We are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #3061 --------- Co-authored-by: Parth Ajmera <[email protected]> ecce6b7
github-actions Bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Jun 18, 2026
…apis#3465) ## Description > [!NOTE] > This PR builds upon googleapis#3387 by patching a function name [issue](googleapis#3387 (comment)). A separate, follow-up PR will be created to add unit and integration tests for SQLCommenter. As an extension to SQLCommenter functionality, we are introducing a new configuration flag, `sqlCommenter`, that can be specified per source in tools.yaml to enable SQL commenting at the source level. This source-specific flag takes precedence over the global `--sql-commenter` flag when configured. If `sqlCommenter` is not explicitly set for a source, the global `--sql-commenter` flag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users. > [!IMPORTANT] > We are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#3061 --------- Co-authored-by: Parth Ajmera <[email protected]> ecce6b7
github-actions Bot
pushed a commit
to rodineyw/mcp-toolbox
that referenced
this pull request
Jun 18, 2026
…apis#3465) ## Description > [!NOTE] > This PR builds upon googleapis#3387 by patching a function name [issue](googleapis#3387 (comment)). A separate, follow-up PR will be created to add unit and integration tests for SQLCommenter. As an extension to SQLCommenter functionality, we are introducing a new configuration flag, `sqlCommenter`, that can be specified per source in tools.yaml to enable SQL commenting at the source level. This source-specific flag takes precedence over the global `--sql-commenter` flag when configured. If `sqlCommenter` is not explicitly set for a source, the global `--sql-commenter` flag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users. > [!IMPORTANT] > We are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#3061 --------- Co-authored-by: Parth Ajmera <[email protected]> ecce6b7
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Jun 18, 2026
…apis#3465) ## Description > [!NOTE] > This PR builds upon googleapis#3387 by patching a function name [issue](googleapis#3387 (comment)). A separate, follow-up PR will be created to add unit and integration tests for SQLCommenter. As an extension to SQLCommenter functionality, we are introducing a new configuration flag, `sqlCommenter`, that can be specified per source in tools.yaml to enable SQL commenting at the source level. This source-specific flag takes precedence over the global `--sql-commenter` flag when configured. If `sqlCommenter` is not explicitly set for a source, the global `--sql-commenter` flag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users. > [!IMPORTANT] > We are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#3061 --------- Co-authored-by: Parth Ajmera <[email protected]> ecce6b7
github-actions Bot
pushed a commit
to pepe57/genai-toolbox
that referenced
this pull request
Jun 18, 2026
…apis#3465) ## Description > [!NOTE] > This PR builds upon googleapis#3387 by patching a function name [issue](googleapis#3387 (comment)). A separate, follow-up PR will be created to add unit and integration tests for SQLCommenter. As an extension to SQLCommenter functionality, we are introducing a new configuration flag, `sqlCommenter`, that can be specified per source in tools.yaml to enable SQL commenting at the source level. This source-specific flag takes precedence over the global `--sql-commenter` flag when configured. If `sqlCommenter` is not explicitly set for a source, the global `--sql-commenter` flag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users. > [!IMPORTANT] > We are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite. ## PR Checklist - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/mcp-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/mcp-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#3061 --------- Co-authored-by: Parth Ajmera <[email protected]> ecce6b7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As an extension to SQLCommenter functionality, we are introducing a new configuration flag,
sqlCommenter, that can be specified per source in tools.yaml to enable SQL commenting at the source level.This source-specific flag takes precedence over the global
--sql-commenterflag when configured. IfsqlCommenteris not explicitly set for a source, the global--sql-commenterflag will continue to determine the behavior. This ensures backward compatibility and avoids any breaking changes for existing users.Also, as discussed with @anubhav756, we are removing SQLCommenter support in MSSQL and cloud MSSQL, and adding its support to SQLite
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #3061