fix(internal/librarian): remove update-image-tag command#804
Closed
cuiy0006 wants to merge 13 commits intogoogleapis:mainfrom
Closed
fix(internal/librarian): remove update-image-tag command#804cuiy0006 wants to merge 13 commits intogoogleapis:mainfrom
cuiy0006 wants to merge 13 commits intogoogleapis:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 23.42% 24.97% +1.55%
==========================================
Files 24 22 -2
Lines 2075 1850 -225
==========================================
- Hits 486 462 -24
+ Misses 1570 1369 -201
Partials 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhumin8
requested changes
Jul 8, 2025
Signed-off-by: Yao Cui <[email protected]>
zhumin8
reviewed
Jul 8, 2025
Temporarily moving the definition of the state file into raw Go structs. The generated proto dir is a big hit to coverage so removing it more proactively will help us have more accurate metrics. Updates: googleapis#744 Fixes: googleapis#774
Contributor
Author
|
Too many conflicts, redo pr. |
auto-merge was automatically disabled
July 9, 2025 14:38
Pull request was closed
julieqiu
pushed a commit
that referenced
this pull request
Jul 30, 2025
julieqiu
pushed a commit
that referenced
this pull request
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
update-image-tagcommand and associated code referenced by it to simplify the codebase.The docs and comments will be further cleaned up in the following PR and being tracked by #802.
Fixes #778