Repository navigation
impl(rust): skip semver checks for proc-macro crates - #7733
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a check to skip semver validation for Rust procedural macro crates, which do not export a standard library API surface for cargo-semver-checks to inspect. It updates the manifest parsing to detect the proc-macro setting and adds corresponding tests. The feedback suggests simplifying boolean assertions in the new tests by using direct comparison instead of cmp.Diff.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Darren Bolduc <[email protected]>
dbolduc
marked this pull request as ready for review
September 29, 2026 21:42
suzmue
approved these changes
Sep 29, 2026
dbolduc
added a commit
to googleapis/google-cloud-rust
that referenced
this pull request
Sep 30, 2026
To pick up googleapis/librarian#7733 The release commands use the librarian version from `librarian.yaml`. While we could go off script, I think I'd rather update librarian and then run commands exactly as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7732 and unblocks the rust release.