Conversation
godot is a linter that checks if all top-level comments contain a period at the end of the last sentence if needed. Enable it as part of golangci-lint. For #638
jba
previously approved these changes
Jun 29, 2025
jskeet
reviewed
Jun 30, 2025
julieqiu
changed the title
julieqiu
changed the title
julieqiu
changed the title
jskeet
approved these changes
Jun 30, 2025
Contributor
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
Approving as-is, but with one change that we may or may not want to include in this PR.
julieqiu
added a commit
that referenced
this pull request
Jul 31, 2025
godot is a linter that checks if all top-level comments contain a period at the end of the last sentence if needed. Enable it as part of golangci-lint. For #638
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
godot is a linter that checks if all top-level comments contain a period at the end of the last sentence if needed. Enable it as part of golangci-lint.
For #638