docs: add initial architecture and container contract docs#655
docs: add initial architecture and container contract docs#655jskeet merged 2 commits intogoogleapis:mainfrom
Conversation
|
This isn't marked as fixing 265, as I expect we'll want to add more - but I wanted to get feedback on what I've already written. (That feedback may well include "topic X doesn't belong in an architecture doc" or "topic Y needs to be covered in the architecture doc" of course.) |
|
@zhumin8 @JoeWang1127 @chingor13 @cuiy0006 @dangazineu @meltsufin - would you mind reviewing this also, and leaving comments / questions about anything that needs clarification? @jskeet - I'll plan on reviewing this tomorrow / Monday |
|
@jskeet - would you mind copying this to a Google doc and sharing with the team for feedback? I started to review, and think it will be easier to leave comments in a doc, then paste it back in |
|
Done: go/sdk-librarian-pr655 |
|
Thanks @jba - I'll copy all of these into our internal doc in the morning (where I suspect there will be more comments). |
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
All changes made in the internal doc. I've left a couple of comments open deliberately for further input.
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
I am good landing what we have here as is. Once this is merged I will update some of our issues to say update these as a part of their task.
|
@codyoss I'll apply the changes I've already got internally, because they fix some typos etc and link to the v0.1.0 code - after which we should merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
=======================================
Coverage ? 19.88%
=======================================
Files ? 27
Lines ? 2892
Branches ? 0
=======================================
Hits ? 575
Misses ? 2293
Partials ? 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@codyoss Internal changes are now in a second commit. If you're happy with those, I'll resolve the remaining comments and dismiss the request for changes, then squash and merge. |
jskeet
dismissed
julieqiu’s stale review
Dismissing review as we've done what was requested, and Julie is away.
4 participants
For #265
Fixes #330