chore(internal/legacylibrarian): sync library versions in configuration#4961
chore(internal/legacylibrarian): sync library versions in configuration#4961JoeWang1127 merged 8 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces logic to synchronize library versions from the legacy librarian state into the librarian.yaml configuration file during the release process. It adds a syncVersion utility that updates the configuration and includes checks to prevent version regressions, supported by new unit tests. Review feedback identifies a bug where arguments in a regression error message are swapped and suggests using a repository-defined constant for the configuration file path to improve maintainability.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4961 +/- ##
==========================================
+ Coverage 81.42% 81.44% +0.01%
==========================================
Files 135 135
Lines 10791 10814 +23
==========================================
+ Hits 8787 8807 +20
- Misses 1355 1357 +2
- Partials 649 650 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeWang1127
changed the title
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
Just one small things, else LGTM
Remove `syncversion` tool because legacylibrarian release stage will sync library version from state.yaml to librarian.yaml (#4961). No need to run this tool manually.
2 participants
The release stage now updates librarian.yaml with the latest library versions after saving the local state. This ensures that the generated configuration file stays in sync with the repository state during legacy releases.
The sync process detects version regressions and automatically runs the formatting utility on the updated configuration.
Fixes #4950