fix(internal/serviceconfig): port release_level info for java from generation_config.yaml#4862
Merged
zhumin8 merged 3 commits intogoogleapis:mainfrom Mar 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the internal/serviceconfig/sdk.yaml file to add java: preview to the release_level configuration for numerous service paths. The feedback indicates that the update is currently incomplete, as several service paths that support Java were missed and still lack the explicit java: preview entry in their release_level blocks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4862 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 130 130
Lines 10910 10910
=======================================
Hits 8879 8879
Misses 1392 1392
Partials 639 639 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeWang1127
approved these changes
Mar 27, 2026
Contributor
JoeWang1127
left a comment
JoeWang1127
left a comment
There was a problem hiding this comment.
Could you add the command in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports over release_level info from google-cloud-java/generation_config.yaml to sdk.yaml. Filled out "preview" for empty values (default in java's current hermetic build logic), removed "stable" as it is default.
Changes are made by running a temporarily script (included in commit 957dceb for record sake).
go run tool/cmd/java_release_level_migrate/main.go --java-repo <path-to-google-cloud-java-repo>This is a fix after #4835 moved the source of truth for release levels to sdk.yaml.
Fix #4859