feat(internal/librarian/java): pass repo and artifact to gapic-generator-java#4775
feat(internal/librarian/java): pass repo and artifact to gapic-generator-java#4775zhumin8 merged 2 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4775 +/- ##
==========================================
+ Coverage 80.63% 80.91% +0.27%
==========================================
Files 128 128
Lines 10733 10728 -5
==========================================
+ Hits 8655 8681 +26
+ Misses 1471 1439 -32
- Partials 607 608 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request passes the repository and artifact name to the Java GAPIC generator for observability features. The implementation involves passing configuration through several functions to the GAPIC option resolution logic. Tests are updated to reflect these changes, and a new test for distribution name derivation is included. The logic for deriving the distribution name has been refactored into a shared function, removing code duplication between generate.go and postprocess.go. My review includes one suggestion to improve robustness when handling configuration values.
2 participants
Pass repo and artifact (distribution name) as parameter to gapic-generator-java. This is new feature to support o11y features. Context googleapis/sdk-platform-java#4120.
Fix #4773