fix(internal/legacylibrarian): allow parsing commits with no space#4061
Merged
codyoss merged 1 commit intogoogleapis:mainfrom Feb 13, 2026
Merged
fix(internal/legacylibrarian): allow parsing commits with no space#4061codyoss merged 1 commit intogoogleapis:mainfrom
codyoss merged 1 commit intogoogleapis:mainfrom
Conversation
A recent commit in googleapis had no space after the conventional commit sperator. We need to be able to parse a commit like this. Fixes: googleapis#4060
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4061 +/- ##
=======================================
Coverage 82.04% 82.04%
=======================================
Files 78 78
Lines 6515 6515
=======================================
Hits 5345 5345
Misses 825 825
Partials 345 345 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the conventional commit parsing logic in conventional_commits.go to support commit messages without a space after the type/scope separator (:), with a corresponding test case added in conventional_commits_test.go. The changes are well-tested, clean, and no security vulnerabilities were identified.
shollyman
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent commit in googleapis had no space after the conventional commit sperator. We need to be able to parse a commit like this.
Fixes: #4060