fix(internal/legacylibrarian): use 'release:failed' label upon failure#4017
fix(internal/legacylibrarian): use 'release:failed' label upon failure#4017codyoss merged 1 commit intogoogleapis:mainfrom
Conversation
When a release fails to process we don't want to indefinitely retry processing that pull request. We will instead now mark it as failed so future searches from our automation don't find the pull request. In these cases a bug will be opened from a production notification in Google Cloud which will require an engineer to investigate the failure. Internal Bug: b/481308012
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a release:failed label for pull requests that fail during the release process, preventing indefinite retries by automation. The changes are well-implemented, including refactoring the label replacement logic for better reusability and updating tests to cover the new failure scenario. The code is clean and the logic is sound. I have one minor suggestion to improve maintainability by avoiding variable shadowing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4017 +/- ##
==========================================
- Coverage 83.26% 83.23% -0.03%
==========================================
Files 76 76
Lines 6418 6420 +2
==========================================
Hits 5344 5344
- Misses 701 702 +1
- Partials 373 374 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
When a release fails to process we don't want to indefinitely retry processing that pull request. We will instead now mark it as failed so future searches from our automation don't find the pull request. In these cases a bug will be opened from a production notification in Google Cloud which will require an engineer to investigate the failure.
Internal Bug: b/481308012