fix(internal/legacylibrarian): retry on more status codes#3989
Merged
codyoss merged 4 commits intogoogleapis:mainfrom Feb 10, 2026
Merged
fix(internal/legacylibrarian): retry on more status codes#3989codyoss merged 4 commits intogoogleapis:mainfrom
codyoss merged 4 commits intogoogleapis:mainfrom
Conversation
GitHub had an outage yesterday which was cauing some of our jobs to fail for a while. While this was happening I noticed we were getting and not honoring these two statuses from thier serveres. Internal Bug: b/483305951
codyoss
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds retry logic for HTTP status codes 500 and 429, correctly honoring the Retry-After header to improve the robustness of GitHub API interactions. However, a medium-severity Denial of Service (DoS) vulnerability was identified: the Retry-After header value is not validated, which could lead to excessive sleep times if a malicious server provides an extremely large value. It is recommended to cap this delay.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3989 +/- ##
==========================================
+ Coverage 83.20% 83.27% +0.06%
==========================================
Files 74 74
Lines 6349 6361 +12
==========================================
+ Hits 5283 5297 +14
+ Misses 696 695 -1
+ Partials 370 369 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeWang1127
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub had an outage yesterday which was cauing some of our jobs to fail for a while. While this was happening I noticed we were getting and not honoring these two statuses from thier serveres.
Internal Bug: b/483305951