Skip to content

test: reuse already defined openAPIFile in test#3944

Merged
zhumin8 merged 1 commit intomainfrom
fix-openapi
Feb 6, 2026
Merged

test: reuse already defined openAPIFile in test#3944
zhumin8 merged 1 commit intomainfrom
fix-openapi

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented Feb 6, 2026

reuse already defined openAPIFile var in test to reduce duplication.

Followup to #3943 (comment)

@zhumin8 zhumin8 requested a review from a team February 6, 2026 20:06
@zhumin8 zhumin8 enabled auto-merge (squash) February 6, 2026 20:06
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully reuses the openAPIFile variable in TestCreateModelOpenAPI, which effectively reduces code duplication and improves maintainability within the test file. This is a good refactoring change.

@JoeWang1127
Copy link
Copy Markdown
Contributor

Why the production code is not changed?

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.35%. Comparing base (bcbac48) to head (6b92de9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3944   +/-   ##
=======================================
  Coverage   83.35%   83.35%           
=======================================
  Files          69       69           
  Lines        6188     6188           
=======================================
  Hits         5158     5158           
  Misses        671      671           
  Partials      359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhumin8 zhumin8 merged commit 9633c10 into main Feb 6, 2026
16 checks passed
@zhumin8 zhumin8 deleted the fix-openapi branch February 6, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants