Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the path to secretmanager_openapi_v1.json across several files. No vulnerabilities were found. There is a suggestion to improve maintainability in a test file by using an existing variable instead of reconstructing the path, aligning with the principle of reusing existing logic for consistency.
coryan
approved these changes
Feb 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
=======================================
Coverage 83.35% 83.35%
=======================================
Files 69 69
Lines 6188 6188
=======================================
Hits 5158 5158
Misses 671 671
Partials 359 359 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhumin8
added a commit
that referenced
this pull request
Feb 6, 2026
reuse already defined openAPIFile var in test to reduce duplication. Followup to #3943 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix path in api.go to be
OpenAPI: "testdata/secretmanager_openapi_v1.json", and change tests accordingly.Fix #3936