feat(internal/librarian): find release commits and libraries released#3642
feat(internal/librarian): find release commits and libraries released#3642jskeet merged 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3642 +/- ##
==========================================
+ Coverage 82.46% 82.51% +0.04%
==========================================
Files 140 140
Lines 12669 12713 +44
==========================================
+ Hits 10448 10490 +42
- Misses 1731 1732 +1
- Partials 490 491 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new functionality to identify released libraries and find the latest commit associated with a release. The new functions, findReleasedLibraries and findLatestReleaseCommitHash, are well-documented and come with comprehensive, table-driven tests that adhere to the project's testing guidelines. The logic for determining library releases and navigating git history appears sound and covers various edge cases. Overall, this is a solid addition to the codebase.
jskeet
force-pushed
the
find-release-changes
branch
2 times, most recently
from
f7d125b to
863db48
Compare
Add findReleasedLibraries, which determines which libraries are released by a specific commit. Add findLatestReleaseCommit, which looks back in git history to find the first commit to release either any library, or just a specified library. These will be used by the tag and publish commands. Fixes googleapis#3597
jskeet
force-pushed
the
find-release-changes
branch
from
863db48 to
a81efc3
Compare
2 participants
Add findReleasedLibraries, which determines which libraries are released by a specific commit.
Add findLatestReleaseCommit, which looks back in git history to find the first commit to release either any library, or just a specified library.
These will be used by the tag and publish commands.
Fixes #3597