feat(internal/command): add command execution package with logging#2968
Merged
julieqiu merged 2 commits intogoogleapis:mainfrom Nov 20, 2025
Merged
feat(internal/command): add command execution package with logging#2968julieqiu merged 2 commits intogoogleapis:mainfrom
julieqiu merged 2 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2968 +/- ##
==========================================
- Coverage 83.15% 83.12% -0.03%
==========================================
Files 137 137
Lines 11053 11052 -1
==========================================
- Hits 9191 9187 -4
- Misses 1445 1448 +3
Partials 417 417 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
previously approved these changes
Nov 20, 2025
An internal/command package is created to execute external commands and print them to stderr before execution, in order to provide progress reports to the user. Existing call sites from internal/sidekick/external are migrated to use the new package and the old package is deleted.
dbolduc
approved these changes
Nov 20, 2025
ldetmer
added a commit
that referenced
this pull request
Nov 20, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: not available Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.7.0</summary> ## [0.7.0](v0.6.0...v0.7.0) (2025-11-20) ### Features * add command execution package with logging (#2968) ([12f4e94](12f4e949)) * add branch support to RepositoryConfig (#2906) ([2cab5d6](2cab5d65)) * add image sha as a config in repositories config (#2954) ([3d1f537](3d1f5375)) * add initial config (#2965) ([502b063](502b063c)) * add fetch package (#2964) ([53de44d](53de44d8)) * parse gapic_metadata for API version release notes (#2815) ([7ee0328](7ee03283)) * onboard 25 repositories to automation for publish-release (#2907) ([87fae04](87fae04a)) * add version command (#2894) ([8f85be0](8f85be09)) * add RequireCommand test helper (#2978) ([a820a71](a820a710)) * add initial command (#2961) ([c959aea](c959aeae)) * add `stage-release` command (#2902) ([ee05006](ee050065)) ### Bug Fixes * require git v2.28.0 (#2963) ([265ee47](265ee47f)) * enums referenced outside the package (#2952) ([7331816](73318169)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An internal/command package is created to execute external commands and print them to stderr before execution, in order to provide progress reports to the user.
Existing call sites from internal/sidekick/external are migrated to use the new package and the old package is deleted.
For #2966