Skip to content

feat(internal/fetch,sidekick): add fetch package#2964

Merged
julieqiu merged 1 commit intogoogleapis:mainfrom
julieqiu:fetch
Nov 20, 2025
Merged

feat(internal/fetch,sidekick): add fetch package#2964
julieqiu merged 1 commit intogoogleapis:mainfrom
julieqiu:fetch

Conversation

@julieqiu
Copy link
Copy Markdown
Member

@julieqiu julieqiu commented Nov 20, 2025

Move functions related to downloading tarballs and computing checksum to internal/fetch, so that it can be used by code outside of sidekick.

For #2966

@julieqiu julieqiu requested review from a team and coryan November 20, 2025 01:20
@julieqiu julieqiu requested a review from a team as a code owner November 20, 2025 01:20
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.25%. Comparing base (3d1f537) to head (704ddb7).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/fetch/fetch.go 85.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2964      +/-   ##
==========================================
+ Coverage   83.21%   83.25%   +0.03%     
==========================================
  Files         137      138       +1     
  Lines       11045    11047       +2     
==========================================
+ Hits         9191     9197       +6     
+ Misses       1437     1435       -2     
+ Partials      417      415       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julieqiu julieqiu removed request for a team November 20, 2025 02:28
Move functions related to downloading tarballs and computing checksum to
internal/fetch, so that it can be used by code outside of sidekick.
@julieqiu julieqiu requested review from a team and removed request for coryan November 20, 2025 02:48
@julieqiu julieqiu merged commit 53de44d into googleapis:main Nov 20, 2025
9 of 10 checks passed
ldetmer added a commit that referenced this pull request Nov 20, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: not available
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest
<details><summary>librarian: 0.7.0</summary>

##
[0.7.0](v0.6.0...v0.7.0)
(2025-11-20)

### Features

* add command execution package with logging (#2968)
([12f4e94](12f4e949))

* add branch support to RepositoryConfig (#2906)
([2cab5d6](2cab5d65))

* add image sha as a config in repositories config (#2954)
([3d1f537](3d1f5375))

* add initial config (#2965)
([502b063](502b063c))

* add fetch package (#2964)
([53de44d](53de44d8))

* parse gapic_metadata for API version release notes (#2815)
([7ee0328](7ee03283))

* onboard 25 repositories to automation for publish-release (#2907)
([87fae04](87fae04a))

* add version command (#2894)
([8f85be0](8f85be09))

* add RequireCommand test helper (#2978)
([a820a71](a820a710))

* add initial command (#2961)
([c959aea](c959aeae))

* add `stage-release` command (#2902)
([ee05006](ee050065))

### Bug Fixes

* require git v2.28.0 (#2963)
([265ee47](265ee47f))

* enums referenced outside the package (#2952)
([7331816](73318169))

</details>
@julieqiu julieqiu deleted the fetch branch December 31, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants