Skip to content

feat(internal/automation): add stage-release command#2902

Merged
JoeWang1127 merged 7 commits intomainfrom
feat/add-stage-release
Nov 13, 2025
Merged

feat(internal/automation): add stage-release command#2902
JoeWang1127 merged 7 commits intomainfrom
feat/add-stage-release

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Nov 13, 2025

Add a stage-release command for automation command set.

For #2416

@JoeWang1127
Copy link
Copy Markdown
Contributor Author

JoeWang1127 commented Nov 13, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new stage-release command to the automation toolset. The implementation is well-structured and follows the existing patterns for other commands. My review focuses on a missing feature and test improvements. The new command is missing support for the -push flag, which appears to be required by the CI/CD infrastructure. I've provided suggestions to add this functionality and to enhance the corresponding tests to ensure correctness. Overall, this is a good addition with the recommended changes.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.33%. Comparing base (8f85be0) to head (476ad98).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/automation/automation.go 71.42% 3 Missing and 1 partial ⚠️
internal/automation/cli.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2902   +/-   ##
=======================================
  Coverage   83.32%   83.33%           
=======================================
  Files         132      133    +1     
  Lines       10902    10930   +28     
=======================================
+ Hits         9084     9108   +24     
- Misses       1406     1409    +3     
- Partials      412      413    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review November 13, 2025 20:48
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner November 13, 2025 20:48
ldetmer
ldetmer previously approved these changes Nov 13, 2025
View reviewed changes
@ldetmer ldetmer self-requested a review November 13, 2025 22:02
ldetmer
ldetmer reviewed Nov 13, 2025
View reviewed changes
@JoeWang1127 JoeWang1127 requested a review from ldetmer November 13, 2025 22:29
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) November 13, 2025 22:29
@JoeWang1127 JoeWang1127 merged commit ee05006 into main Nov 13, 2025
9 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/add-stage-release branch November 13, 2025 22:50
@ldetmer ldetmer mentioned this pull request Nov 20, 2025
Merged
ldetmer added a commit that referenced this pull request Nov 20, 2025
@ldetmer
chore: librarian release pull request: 20251120T152217Z (#2982)
6e4de1e 
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: not available
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest
<details><summary>librarian: 0.7.0</summary>

##
[0.7.0](v0.6.0...v0.7.0)
(2025-11-20)

### Features

* add command execution package with logging (#2968)
([12f4e94](12f4e949))

* add branch support to RepositoryConfig (#2906)
([2cab5d6](2cab5d65))

* add image sha as a config in repositories config (#2954)
([3d1f537](3d1f5375))

* add initial config (#2965)
([502b063](502b063c))

* add fetch package (#2964)
([53de44d](53de44d8))

* parse gapic_metadata for API version release notes (#2815)
([7ee0328](7ee03283))

* onboard 25 repositories to automation for publish-release (#2907)
([87fae04](87fae04a))

* add version command (#2894)
([8f85be0](8f85be09))

* add RequireCommand test helper (#2978)
([a820a71](a820a710))

* add initial command (#2961)
([c959aea](c959aeae))

* add `stage-release` command (#2902)
([ee05006](ee050065))

### Bug Fixes

* require git v2.28.0 (#2963)
([265ee47](265ee47f))

* enums referenced outside the package (#2952)
([7331816](73318169))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldetmer ldetmer ldetmer approved these changes

@zhumin8 zhumin8 Awaiting requested review from zhumin8

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoeWang1127 @ldetmer