Skip to content

fix: revert change to use tag command#2812

Merged
ldetmer merged 1 commit intomainfrom
ldetmer-patch-5
Nov 6, 2025
Merged

fix: revert change to use tag command#2812
ldetmer merged 1 commit intomainfrom
ldetmer-patch-5

Conversation

@ldetmer
Copy link
Copy Markdown
Contributor

@ldetmer ldetmer commented Nov 6, 2025

We have not rolled out the new Librarian image, so we should still be using the tag-and-release command in automation

fixes #2811

We have not rolled out the new Librarian image, so we should still be using the tag-and-release command in automation

Signed-off-by: ldetmer <[email protected]>
@ldetmer ldetmer requested a review from a team as a code owner November 6, 2025 18:00
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ldetmer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an incompatibility in the release automation pipeline by reverting a recent change. It ensures that the 'tag-and-release' command is used for publishing releases, as the 'tag' command is not yet supported due to the new Librarian image not being deployed. This change prevents potential disruptions in the release process and maintains operational stability.

Highlights

  • Revert Release Command: The pull request reverts a previous change in the release automation, switching the command used for publishing releases from 'tag' back to 'tag-and-release'.
  • Librarian Image Compatibility: This revert is necessary because the new Librarian image, which would support the 'tag' command, has not yet been rolled out, ensuring compatibility with current automation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the librarian command in infra/prod/publish-release.yaml from release tag back to release tag-and-release. This is a necessary temporary fix as the new librarian image that supports the tag command has not been rolled out yet. The change is correct given the context. I've left one comment regarding an outdated comment in the configuration file that should be updated to maintain consistency.

@ldetmer ldetmer enabled auto-merge (squash) November 6, 2025 18:02
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.64%. Comparing base (f360e18) to head (45bbfe3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2812   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         120      120           
  Lines       10293    10293           
=======================================
  Hits         8918     8918           
  Misses        970      970           
  Partials      405      405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldetmer ldetmer merged commit 3e3b1cd into main Nov 6, 2025
9 of 10 checks passed
@ldetmer ldetmer deleted the ldetmer-patch-5 branch November 6, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian: publish-release job is failing for last release

3 participants