Skip to content

feat(java): release stage to update pom.xml files#2772

Merged
suztomo merged 17 commits intogoogleapis:mainfrom
suztomo:pom.xml_versions
Nov 5, 2025
Merged

feat(java): release stage to update pom.xml files#2772
suztomo merged 17 commits intogoogleapis:mainfrom
suztomo:pom.xml_versions

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Nov 4, 2025

The 1st part of the release stage command for Java is updating pom.xml files.

  • It adds "-SNAPSHOT" version to the version value provided in the release stage request.

For #2516

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 32.00000% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.50%. Comparing base (f15e612) to head (d7591dd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/container/java/pom/pom_update.go 20.51% 29 Missing and 2 partials ⚠️
internal/container/java/release/release.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
- Coverage   86.74%   86.50%   -0.24%     
==========================================
  Files         119      120       +1     
  Lines       10183    10232      +49     
==========================================
+ Hits         8833     8851      +18     
- Misses        949      977      +28     
- Partials      401      404       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suztomo suztomo marked this pull request as ready for review November 4, 2025 19:46
@suztomo suztomo requested a review from a team as a code owner November 4, 2025 19:46
@suztomo suztomo changed the title feat(java): release init to update pom.xml feat(java): release stage to update pom.xml files Nov 4, 2025
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 4, 2025

All tests passed.

@suztomo suztomo enabled auto-merge (squash) November 4, 2025 21:17
@suztomo
Copy link
Copy Markdown
Member Author

suztomo commented Nov 5, 2025

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces functionality to update pom.xml files during the Java release stage. A new pom package is added to handle finding and replacing version strings, guided by special comments in the XML files. The changes are accompanied by a good set of unit tests. My review includes suggestions to improve code clarity by removing redundant code, and to align with idiomatic Go error handling practices for better maintainability.

@suztomo suztomo requested a review from ldetmer November 5, 2025 16:23
@suztomo suztomo merged commit be56755 into googleapis:main Nov 5, 2025
6 checks passed
@suztomo suztomo deleted the pom.xml_versions branch November 5, 2025 20:19
ldetmer added a commit that referenced this pull request Nov 6, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: not available
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest
<details><summary>librarian: 1.0.0</summary>

##
[1.0.0](v0.5.0...v1.0.0)
(2025-11-06)

### Features

* Remove `..._gax` dependency (#2713)
([01675b7](01675b72))

* add context to Librarian PRs (#2698)
([0523329](0523329a))

* add a package comment linter (#2712)
([1bd3e32](1bd3e32e))

* generate pom.xml files (#2682)
([50b95f2](50b95f20))

* add test-container test logic (#2656)
([514cf7e](514cf7e5))

* improve rust-publish logging (#2671)
([585ed50](585ed50b))

* write a timing log at the end of update-image (#2771)
([5fc9e3b](5fc9e3b6))

* migrate Java container from sdk-platform-java (#2670)
([69ac47f](69ac47fd))

* switch to original head after running update-image (#2696)
([7a3e404](7a3e404a))

* format bulk commit from other sources in release notes (#2665)
([7c52da2](7c52da2b))

* enable multi-version API generation (#2699)
([86c5250](86c52507))

* release stage to update pom.xml files (#2772)
([be56755](be567550))

* use proto presence info to generate null-safe code (#2726)
([e36fb81](e36fb81a))

* Base messages in google_cloud_protobuf (#2660)
([e607ea6](e607ea63))

### Bug Fixes

* retry Github 503 requests up to 3 times (#2650)
([09468fa](09468faf))

* Changed docs to ConfigurationException (#2697)
([0950c1e](0950c1e3))

* fix the reference to the old &#34;librariangen&#34; folder (#2677)
([09dc53f](09dc53fe))

* run godoclint via golangci-lint (#2751)
([264a6a0](264a6a0e))

* pass context as the first argument (#2769)
([298a3bd](298a3bd8))

* Move HTTP client creation to `_gax` (#2672)
([4968d63](4968d63d))

* deduplicate bulk commits (#2758)
([4dfae9a](4dfae9ae))

* Support additional api paths for an existing library (#2666)
([50046f5](50046f55))

* remove stray TODO (#2748)
([5072f0e](5072f0e0))

* omit status field when empty (#2654)
([572ae4f](572ae4f3))

* use T.Context in tests (#2768)
([7e7cd2d](7e7cd2dd))

* wrap error to provide more context for commitAndPush (#2767)
([a2a41a4](a2a41a4a))

* use t.Fatal in tests for proper failure handling (#2759)
([cdabb28](cdabb287))

* enforce removal before copying library files (#2765)
([d5ac6c8](d5ac6c87))

* change log level to debug (#2798)
([f042d0b](f042d0bd))

* change path to `doc.go` in docgen test (#2700)
([fd6bae4](fd6bae40))

### Documentation

* use consistent library id in flags and examples (#2770)
([87a1005](87a10056))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants