Skip to content

chore: remove legacy architecture documentation#2752

Merged
ldetmer merged 1 commit intomainfrom
legacy-arch-removal
Nov 3, 2025
Merged

chore: remove legacy architecture documentation#2752
ldetmer merged 1 commit intomainfrom
legacy-arch-removal

Conversation

@ldetmer
Copy link
Copy Markdown
Contributor

@ldetmer ldetmer commented Nov 3, 2025

This was a mix of architecture and usage guide for legacy librarian system. Instead this has been replaced by high level architecture guide and usage guide

fixes #2744

@ldetmer ldetmer requested a review from a team as a code owner November 3, 2025 14:28
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ldetmer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on streamlining the project's documentation by removing outdated architecture information and pointing users to more current and relevant guides. This improves maintainability and ensures users are referencing the most up-to-date information.

Highlights

  • Documentation Removal: This PR removes the legacy architecture documentation (doc/architecture.md).
  • Replacement with Updated Guides: The removed documentation has been replaced by a high-level architecture guide and a usage guide, both located in the doc/ directory.
  • Issue Resolution: This change addresses and closes issue doc: update architecture.md to reflect current architecture #2744.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.93%. Comparing base (f5faacf) to head (b35ccdb).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2752   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files         118      118           
  Lines        9895     9895           
=======================================
  Hits         8602     8602           
  Misses        914      914           
  Partials      379      379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the legacy architecture.md file, which documented an old version of the Librarian system. As mentioned in the pull request description, this information has been superseded by the high-level architecture guide and the library maintainer guide. This is a good documentation cleanup. I have verified that no other documents in the repository link to the removed file, so there are no broken references. The change is approved.

@ldetmer ldetmer merged commit 6bce27d into main Nov 3, 2025
9 of 10 checks passed
@ldetmer ldetmer deleted the legacy-arch-removal branch November 3, 2025 20:03
zhumin8 pushed a commit to zhumin8/librarian that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: update architecture.md to reflect current architecture

2 participants