Skip to content

feat: add context to Librarian PRs#2698

Merged
JoeWang1127 merged 8 commits intomainfrom
feat/add-context-prs
Oct 28, 2025
Merged

feat: add context to Librarian PRs#2698
JoeWang1127 merged 8 commits intomainfrom
feat/add-context-prs

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

Fixes #2695

@JoeWang1127
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a contextual introductory sentence to the body of pull requests generated by the Librarian CLI. The changes are consistent across generation, onboarding, and release PRs. The implementation correctly updates the Go templates and their corresponding tests. I have one suggestion to improve maintainability by extracting the new hardcoded strings into constants.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.84%. Comparing base (7a3e404) to head (048ece7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2698   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files         118      118           
  Lines        9795     9795           
=======================================
  Hits         8506     8506           
  Misses        912      912           
  Partials      377      377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review October 28, 2025 18:04
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner October 28, 2025 18:04
@JoeWang1127 JoeWang1127 requested a review from ldetmer October 28, 2025 18:04
ldetmer
ldetmer previously approved these changes Oct 28, 2025
@JoeWang1127 JoeWang1127 disabled auto-merge October 28, 2025 18:56
ldetmer
ldetmer previously approved these changes Oct 28, 2025
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) October 28, 2025 19:00
@JoeWang1127 JoeWang1127 merged commit 0523329 into main Oct 28, 2025
8 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/add-context-prs branch October 28, 2025 19:03
ldetmer added a commit that referenced this pull request Nov 6, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: not available
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest
<details><summary>librarian: 1.0.0</summary>

##
[1.0.0](v0.5.0...v1.0.0)
(2025-11-06)

### Features

* Remove `..._gax` dependency (#2713)
([01675b7](01675b72))

* add context to Librarian PRs (#2698)
([0523329](0523329a))

* add a package comment linter (#2712)
([1bd3e32](1bd3e32e))

* generate pom.xml files (#2682)
([50b95f2](50b95f20))

* add test-container test logic (#2656)
([514cf7e](514cf7e5))

* improve rust-publish logging (#2671)
([585ed50](585ed50b))

* write a timing log at the end of update-image (#2771)
([5fc9e3b](5fc9e3b6))

* migrate Java container from sdk-platform-java (#2670)
([69ac47f](69ac47fd))

* switch to original head after running update-image (#2696)
([7a3e404](7a3e404a))

* format bulk commit from other sources in release notes (#2665)
([7c52da2](7c52da2b))

* enable multi-version API generation (#2699)
([86c5250](86c52507))

* release stage to update pom.xml files (#2772)
([be56755](be567550))

* use proto presence info to generate null-safe code (#2726)
([e36fb81](e36fb81a))

* Base messages in google_cloud_protobuf (#2660)
([e607ea6](e607ea63))

### Bug Fixes

* retry Github 503 requests up to 3 times (#2650)
([09468fa](09468faf))

* Changed docs to ConfigurationException (#2697)
([0950c1e](0950c1e3))

* fix the reference to the old &#34;librariangen&#34; folder (#2677)
([09dc53f](09dc53fe))

* run godoclint via golangci-lint (#2751)
([264a6a0](264a6a0e))

* pass context as the first argument (#2769)
([298a3bd](298a3bd8))

* Move HTTP client creation to `_gax` (#2672)
([4968d63](4968d63d))

* deduplicate bulk commits (#2758)
([4dfae9a](4dfae9ae))

* Support additional api paths for an existing library (#2666)
([50046f5](50046f55))

* remove stray TODO (#2748)
([5072f0e](5072f0e0))

* omit status field when empty (#2654)
([572ae4f](572ae4f3))

* use T.Context in tests (#2768)
([7e7cd2d](7e7cd2dd))

* wrap error to provide more context for commitAndPush (#2767)
([a2a41a4](a2a41a4a))

* use t.Fatal in tests for proper failure handling (#2759)
([cdabb28](cdabb287))

* enforce removal before copying library files (#2765)
([d5ac6c8](d5ac6c87))

* change log level to debug (#2798)
([f042d0b](f042d0bd))

* change path to `doc.go` in docgen test (#2700)
([fd6bae4](fd6bae40))

### Documentation

* use consistent library id in flags and examples (#2770)
([87a1005](87a10056))

</details>
zhumin8 pushed a commit to zhumin8/librarian that referenced this pull request Nov 17, 2025
We need to generate (and invoke) a `build.rs` script to generate the
Prost types. We used to leave these scripts in the repo, that was a bad
idea because they exclude the generated code from the packages. They are
also confusing, and kind of ugly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

librarian: add additional context to Librarian PRs

3 participants