tests: another test for adding a new api path to an existing library by parthea · Pull Request #2676 · googleapis/librarian

parthea · 2025-10-24T18:27:12Z

As a follow up to #2666, this PR adds another test case to check that a new API path can be added to an existing library in state.yaml. The test case added in #2666 did not have any API paths in the existing library. See the snippet below where there is no API path in the existing library.

librarian/internal/librarian/generate_command_test.go

Lines 1572 to 1584 in 50046f5

    
           { 
        
           	name:    "api and library set, library exists", 
        
           	api:     "some/api", 
        
           	library: "some-library", 
        
           	state: &config.LibrarianState{ 
        
           		Libraries: []*config.LibraryState{ 
        
           			{ 
        
           				ID: "some-library", 
        
           			}, 
        
           		}, 
        
           	}, 
        
           	want: true, 
        
           },

For completeness and to avoid regressions, we should also test that new paths can be added to an existing library which already has API paths. This PR adds the missing test case.

gemini-code-assist · 2025-10-24T18:27:24Z

Summary of Changes

Hello @parthea, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the test suite for the generate_command by introducing a new test case. This new test specifically validates the functionality of adding a new API path to a library that already has existing API paths defined in its state.yaml configuration. This ensures comprehensive coverage and prevents potential regressions in handling library state updates.

Highlights

Test Coverage Enhancement: Added a new test case to generate_command_test.go to verify that new API paths can be successfully added to an existing library that already contains API paths in state.yaml.
Test Case Refinement: Renamed an existing test case for clarity, specifying that it covers the scenario where an existing library has no API paths in state.yaml.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds a new test case to TestNeedsConfigure to ensure that the function correctly identifies when a new API path needs to be added to an existing library that already has API paths defined in state.yaml. The added test case enhances the robustness of the generate command by covering a scenario not previously addressed.

internal/librarian/generate_command_test.go

codecov · 2025-10-24T18:29:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.49%. Comparing base (b5021b8) to head (bd398f0).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2676      +/-   ##
==========================================
+ Coverage   86.69%   87.49%   +0.80%     
==========================================
  Files         118      118              
  Lines        9814    10611     +797     
==========================================
+ Hits         8508     9284     +776     
- Misses        921      922       +1     
- Partials      385      405      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Anthonios Partheniou <[email protected]>

internal/librarian/generate_command_test.go

julieqiu

comment on renaming test

addressed review feedback

julieqiu · 2025-10-31T17:19:52Z

@parthea I think you need to rebase this PR. Looks like some of the failures were recently fixed.

tests: another test for adding a new api path to an existing library

90087e2

parthea requested a review from a team as a code owner October 24, 2025 18:27

gemini-code-assist bot reviewed Oct 24, 2025

View reviewed changes

internal/librarian/generate_command_test.go Outdated Show resolved Hide resolved

internal/librarian/generate_command_test.go Outdated Show resolved Hide resolved

parthea and others added 2 commits October 24, 2025 14:30

Update internal/librarian/generate_command_test.go

aac61c6

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Anthonios Partheniou <[email protected]>

Update internal/librarian/generate_command_test.go

9d2c0a4

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Anthonios Partheniou <[email protected]>

chingor13 previously approved these changes Oct 24, 2025

View reviewed changes

bad indentation

47a93bb

parthea dismissed chingor13’s stale review via 47a93bb October 24, 2025 18:44

JoeWang1127 reviewed Oct 24, 2025

View reviewed changes

internal/librarian/generate_command_test.go Outdated Show resolved Hide resolved

julieqiu approved these changes Oct 30, 2025

View reviewed changes

internal/librarian/generate_command_test.go Outdated Show resolved Hide resolved

julieqiu previously requested changes Oct 30, 2025

View reviewed changes

address feedback

0acdcd0

parthea requested a review from julieqiu October 31, 2025 16:10

parthea self-assigned this Oct 31, 2025

julieqiu approved these changes Oct 31, 2025

View reviewed changes

parthea mentioned this pull request Oct 31, 2025

test: remove build line from e2e_test.go #2735

Closed

Merge branch 'main' into add-test-api-path

bd398f0

parthea enabled auto-merge (squash) October 31, 2025 17:35

parthea merged commit e9fc828 into main Oct 31, 2025
8 checks passed

parthea deleted the add-test-api-path branch October 31, 2025 17:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: another test for adding a new api path to an existing library#2676

tests: another test for adding a new api path to an existing library#2676
parthea merged 6 commits intomainfrom
add-test-api-path

parthea commented Oct 24, 2025

Uh oh!

gemini-code-assist bot commented Oct 24, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

julieqiu left a comment •

edited

Loading

Uh oh!

julieqiu commented Oct 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	{
	name: "api and library set, library exists",
	api: "some/api",
	library: "some-library",
	state: &config.LibrarianState{
	Libraries: []*config.LibraryState{
	{
	ID: "some-library",
	},
	},
	},
	want: true,
	},

Conversation

parthea commented Oct 24, 2025

Uh oh!

gemini-code-assist bot commented Oct 24, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

julieqiu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

julieqiu commented Oct 31, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Oct 24, 2025 •

edited

Loading

julieqiu left a comment •

edited

Loading