docs: Add Update Image Command to language onboarding doc#2647
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
==========================================
+ Coverage 85.68% 87.44% +1.76%
==========================================
Files 108 108
Lines 11057 9681 -1376
==========================================
- Hits 9474 8466 -1008
+ Misses 1250 873 -377
- Partials 333 342 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
parthea
changed the title
update-image to doc/language-onboarding.md
parthea
changed the title
update-image to doc/language-onboarding.md
parthea
changed the title
|
/gemini review |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request adds documentation for the update-image command to the language onboarding guide. The new documentation explains how to pin the language container version in state.yaml and provides instructions on using the update-image command for this purpose. The documentation also includes a note about potential diffs if the container SHA in state.yaml is updated without using update-image and provides a command example. I have added a review comment to improve the clarity of the documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Anthonios Partheniou <[email protected]>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the update-image command to the language onboarding guide. The new section clearly explains the purpose and usage of the command, which is a valuable addition. I have one minor suggestion to improve the formatting of a command example for better readability and consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Anthonios Partheniou <[email protected]>
Co-authored-by: ldetmer <[email protected]> Signed-off-by: Anthonios Partheniou <[email protected]>
As per #2647 (comment), we now have a system that keeps cli docs up-to-date as we change them. We dynamically create docs based on helptext: https://pkg.go.dev/github.com/googleapis/librarian/cmd/librarian. This PR removes the obsolete file `doc/cli-commands.md`
4 participants
Fixes #2646