feat(dart): Include a correct URL for issues by brianquinlan · Pull Request #2570 · googleapis/librarian

brianquinlan · 2025-10-14T17:37:04Z

Fixes the generation side of googleapis/google-cloud-dart#8

gemini-code-assist · 2025-10-14T17:37:20Z

Summary of Changes

Hello @brianquinlan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new IssueTrackerURL field into the Dart code generation process. This enhancement ensures that generated Dart packages will consistently include a direct and correct link to their respective issue trackers within their README.md files and pubspec.yaml metadata, improving the clarity and accessibility for users seeking to report issues or provide feedback.

Highlights

New Issue Tracker Field: Introduced IssueTrackerURL in the modelAnnotations struct and related logic to store a dedicated issue tracker URL.
Configuration Requirement: Added a validation step to ensure that all service packages define an issue-tracker-url.
Template Integration: Updated README.md.mustache and pubspec.yaml.mustache templates to use the new IssueTrackerURL for accurate issue tracker links.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request adds support for a dedicated issue-tracker-url in the configuration. This URL is then used to populate the issue_tracker field in pubspec.yaml and to provide a correct link in README.md. The changes are well-structured and also include updates to tests. I've found a couple of areas for improvement: one regarding Go naming conventions, a logic bug in the validation, and a suggestion to make the pubspec.yaml generation more robust. Overall, a good feature addition.

internal/sidekick/internal/dart/annotate.go

internal/sidekick/internal/dart/templates/pubspec.yaml.mustache

codecov · 2025-10-14T18:33:37Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.92%. Comparing base (0adeeac) to head (b5363fc).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
- Coverage   85.96%   85.92%   -0.04%     
==========================================
  Files         103      105       +2     
  Lines       10570    10655      +85     
==========================================
+ Hits         9086     9155      +69     
- Misses       1160     1176      +16     
  Partials      324      324

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

internal/sidekick/internal/dart/annotate.go

Librarian Version: v0.0.0-20251022154542-dd249212325d Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.5.0</summary> ## [0.5.0](v0.4.0...v0.5.0) (2025-10-22) ### Features * speed up finding changed files in commits (#2645) ([1060946](10609465)) * Can config dart `export` (#2641) ([97eacd2](97eacd29)) * minor whitespace and doc changes to the Dart templates (#2636) ([b3ac7b4](b3ac7b42)) * only generate libraries with changed APIs (#2618) ([82171be](82171bed)) * make extra modules public (#2622) ([2c94a53](2c94a53f)) * skip a GitHub release for a library (#2612) ([6258f4d](6258f4d1)) * allow skipping semver checks for rust-publish (#2584) ([739ce0d](739ce0d5)) * add ability to open pull request as a draft (#2604) ([c1f0285](c1f02859)) * capture discovery revision (#2605) ([14a1483](14a14830)) * Add conditional instrumentation to gRPC clients (#2594) ([3cc63b2](3cc63b22)) * add update-image CLI command (#2580) ([90e0f6e](90e0f6e5)) * Generate more samples for oneof main setters. (#2592) ([c55f3ce](c55f3ceb)) * Add documentation for generated service constructors (#2575) ([6a4aead](6a4aeade)) * disable some clippy warnings (#2567) ([9f51084](9f510842)) * Generate setter samples for oneof fields. (#2573) ([8c2416a](8c2416ab)) * add default Rust features option (#2562) ([892f42b](892f42b7)) * Include a correct URL for issues (#2570) ([10493ed](10493ed9)) * add ability to find the latest docker image SHA (#2539) ([62e80f1](62e80f19)) * add ability to checkout a repo at a certain commit (#2555) ([23b8ffe](23b8ffea)) * add onboarding PR body (#2552) ([e32719c](e32719cd)) ### Bug Fixes * associate bulk change to individual libraries (#2626) ([dd24921](dd249212)) * Allow `unnecessary_import`s (#2642) ([88c4379](88c43794)) * resolve issue where onboarded library can't be released (#2632) ([b300a4e](b300a4ea)) * resolve issue where commits cannot be fetched for new library (#2631) ([45652c0](45652c03)) * address a typo in the Message.ServicePlaceholder docs (#2616) ([82fda96](82fda96b)) * bad version bump edits (#2613) ([9902b1d](9902b1d5)) * use templates for update-image PR body (#2602) ([7309cad](7309cadd)) * populate configure command pr content (#2591) ([811eb8e](811eb8e2)) * shrink release PR size when there are bulk changes (#2585) ([bcb914a](bcb914ac)) * Fixes several issues with oneof main setter samples (#2589) ([e4958d0](e4958d00)) * resolve broken link in PR body (#2579) ([098c1d2](098c1d24)) * Remove double sample code blocks (#2582) ([6b10456](6b104567)) * change commit package (#2571) ([45ee48f](45ee48f0)) * show chores in release notes (#2544) ([88b62cc](88b62ccb)) * avoid work duplication when finding changes (#2558) ([0adeeac](0adeeac6)) * mangled method names and doc links (#2565) ([895dac9](895dac94)) ### Reverts * show chores in release notes (#2601) ([7e6740f](7e6740ff)) </details>

brianquinlan added 5 commits October 10, 2025 16:51

feat(dart): Include a correct URL for issues

24e0eb6

More issue tracker work

d8598a7

Merge remote-tracking branch 'upstream/main' into issue_url

895278e

Fixes

8d3ab00

Require an issue tracker URL

8c68f51

brianquinlan requested a review from a team October 14, 2025 17:37

natebosch previously approved these changes Oct 14, 2025

View reviewed changes

gemini-code-assist bot reviewed Oct 14, 2025

View reviewed changes

internal/sidekick/internal/dart/annotate.go Outdated Show resolved Hide resolved

internal/sidekick/internal/dart/annotate.go Outdated Show resolved Hide resolved

internal/sidekick/internal/dart/templates/pubspec.yaml.mustache Show resolved Hide resolved

Review and test fixes

17da6df

brianquinlan dismissed natebosch’s stale review via 17da6df October 14, 2025 18:28

coryan reviewed Oct 14, 2025

View reviewed changes

internal/sidekick/internal/dart/annotate.go Outdated Show resolved Hide resolved

internal/sidekick/internal/dart/annotate.go Outdated Show resolved Hide resolved

brianquinlan added 2 commits October 14, 2025 11:47

Add tests for missing required fields

e56681d

Update annotate.go

b5363fc

coryan approved these changes Oct 14, 2025

View reviewed changes

brianquinlan merged commit 10493ed into googleapis:main Oct 14, 2025
6 checks passed

cloud-sdk-librarian-robot mentioned this pull request Oct 22, 2025

chore: librarian release pull request: 20251022T180958Z #2653

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dart): Include a correct URL for issues#2570

feat(dart): Include a correct URL for issues#2570
brianquinlan merged 8 commits intogoogleapis:mainfrom
brianquinlan:issue_url

brianquinlan commented Oct 14, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Oct 14, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

brianquinlan commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 14, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

brianquinlan commented Oct 14, 2025 •

edited

Loading

codecov bot commented Oct 14, 2025 •

edited

Loading