fix(internal/conventionalcommits): keep first value for repeated footer keys#2440
Merged
fix(internal/conventionalcommits): keep first value for repeated footer keys#2440
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 85.12% 85.13%
=======================================
Files 102 102
Lines 10339 10344 +5
=======================================
+ Hits 8801 8806 +5
Misses 1202 1202
Partials 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeWang1127
approved these changes
Sep 29, 2025
suztomo
pushed a commit
that referenced
this pull request
Oct 13, 2025
Librarian Version: v0.0.0-20251009012716-e267b1dfc9b9 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.4.0</summary> ## [0.4.0](v0.3.0...v0.4.0) (2025-10-09) ### Features * add `git log` functionality (#2510) ([e267b1d](e267b1d)) * Modify README.md to match our agreed-upon wording (#2503) ([2dc6fc6](2dc6fc6)) * Show actual enum values on setter samples. (#2491) ([13fd5a1](13fd5a1)) * sort library state when writing to `state.yaml` (#2504) ([35e4495](35e4495)) * Generate methods that use server-side streaming (#2474) ([31a496d](31a496d)) * allow configuring tag_format in config.yaml (#2236) ([e0eeddb](e0eeddb)) * `update` supports different roots (#2473) ([65fa7ed](65fa7ed)) * Support git push via SSH (#2397) ([7259194](7259194)) * mount output dir in configure docker command (#2439) ([365019e](365019e)) * Update templates for otel (#2443) ([ea54ba6](ea54ba6)) * support aggregated pagination (#2432) ([5b010b9](5b010b9)) * override pagination items field (#2441) ([4a3664a](4a3664a)) * include source root in configure request (#2431) ([475a62d](475a62d)) * rust+disco bytes (de)serialization (#2428) ([b2a186c](b2a186c)) * enum serialization for non-proto sources (#2410) ([516f29e](516f29e)) * optional singular fields in discovery (#2408) ([c86c2db](c86c2db)) * deprecated elements in discovery docs (#2399) ([1d83853](1d83853)) * allow "." as valid `source_roots` entry (#2396) ([2f52aa7](2f52aa7)) * inline messages in discovery docs (#2394) ([043cf65](043cf65)) * write pr-body.txt to the work root when not pushing (#2395) ([862c7d7](862c7d7)) * define LIBRARIAN_GITHUB_TOKEN as a constant (#2367) ([5979bfd](5979bfd)) ### Bug Fixes * clarify doc and comment with commit and push flag (#2507) ([645e42a](645e42a)) * keep first value for repeated footer keys (#2440) ([e51490d](e51490d)) * group commit msg if they have the same piper id and subject (#2496) ([60b7d38](60b7d38)) * real runs for `rust-publish` (#2484) ([15d63c2](15d63c2)) * Remove unnecessary dereference in transport template (#2481) ([610cec9](610cec9)) * shorten SHAs in generate commit msgs (#2472) ([de336b1](de336b1)) * handle slashes in library IDs (#2463) ([91c0189](91c0189)) * nil check for github.NewClient (#2465) ([71db17e](71db17e)) * Conventional Commit parser filters files based on Librarian flow (#2433) ([6cb55d2](6cb55d2)) * Ensure detailed-tracing-attributes flag is fully propagated (#2438) ([a184f0d](a184f0d)) * relax footer regex to allow line broke footers to be properly recognized (#2388) ([dcbe063](dcbe063)) * release init provides read-only full repository (#2370) ([2e11004](2e11004)) * write the PR body on "commit but no push" (#2430) ([88698b4](88698b4)) * should not push to github when no push flag specified (#2405) ([2a49ae6](2a49ae6)) * only mount global files in configure command (#2377) ([1a2aaa0](1a2aaa0)) * `Map` field attribute in discovery (#2414) ([00c645f](00c645f)) * missing IDs in discovery doc fields (#2386) ([d579dd7](d579dd7)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Footer with repeated keys is not supported with current implementation, this fix let the first value be kept instead of last. Clarify in doc comment about this limitation.
When onboarding libraries that has generation pr with owlbot and release with Librarian, commit, the first
Source-Link:is useful.Alternative is to refactor
Footerwith typemap[string][]string. It's probably not worth it because the keys we care for Librarian are not expected to repeat. This can be added as enhancement when needed.For #2080