feat(config): define LIBRARIAN_GITHUB_TOKEN as a constant#2367
feat(config): define LIBRARIAN_GITHUB_TOKEN as a constant#2367jinseopkim0 merged 1 commit intomainfrom
Conversation
d671b92 to
c45d716
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 99 99
Lines 10019 10019
=======================================
Hits 8454 8454
Misses 1214 1214
Partials 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change introduces a constant for the LIBRARIAN_GITHUB_TOKEN environment variable to improve maintainability and reduce duplication.
c45d716 to
608f339
Compare
codyoss
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes.
nit: avoid force pushing to a branch after someone has reviewed. It makes it hard for the reviewer to see what has changed since their last review. We always squash and merge anyways 😄
Thank you, I'll keep this in mind. |
Librarian Version: v0.0.0-20251009012716-e267b1dfc9b9 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.4.0</summary> ## [0.4.0](v0.3.0...v0.4.0) (2025-10-09) ### Features * add `git log` functionality (#2510) ([e267b1d](e267b1d)) * Modify README.md to match our agreed-upon wording (#2503) ([2dc6fc6](2dc6fc6)) * Show actual enum values on setter samples. (#2491) ([13fd5a1](13fd5a1)) * sort library state when writing to `state.yaml` (#2504) ([35e4495](35e4495)) * Generate methods that use server-side streaming (#2474) ([31a496d](31a496d)) * allow configuring tag_format in config.yaml (#2236) ([e0eeddb](e0eeddb)) * `update` supports different roots (#2473) ([65fa7ed](65fa7ed)) * Support git push via SSH (#2397) ([7259194](7259194)) * mount output dir in configure docker command (#2439) ([365019e](365019e)) * Update templates for otel (#2443) ([ea54ba6](ea54ba6)) * support aggregated pagination (#2432) ([5b010b9](5b010b9)) * override pagination items field (#2441) ([4a3664a](4a3664a)) * include source root in configure request (#2431) ([475a62d](475a62d)) * rust+disco bytes (de)serialization (#2428) ([b2a186c](b2a186c)) * enum serialization for non-proto sources (#2410) ([516f29e](516f29e)) * optional singular fields in discovery (#2408) ([c86c2db](c86c2db)) * deprecated elements in discovery docs (#2399) ([1d83853](1d83853)) * allow "." as valid `source_roots` entry (#2396) ([2f52aa7](2f52aa7)) * inline messages in discovery docs (#2394) ([043cf65](043cf65)) * write pr-body.txt to the work root when not pushing (#2395) ([862c7d7](862c7d7)) * define LIBRARIAN_GITHUB_TOKEN as a constant (#2367) ([5979bfd](5979bfd)) ### Bug Fixes * clarify doc and comment with commit and push flag (#2507) ([645e42a](645e42a)) * keep first value for repeated footer keys (#2440) ([e51490d](e51490d)) * group commit msg if they have the same piper id and subject (#2496) ([60b7d38](60b7d38)) * real runs for `rust-publish` (#2484) ([15d63c2](15d63c2)) * Remove unnecessary dereference in transport template (#2481) ([610cec9](610cec9)) * shorten SHAs in generate commit msgs (#2472) ([de336b1](de336b1)) * handle slashes in library IDs (#2463) ([91c0189](91c0189)) * nil check for github.NewClient (#2465) ([71db17e](71db17e)) * Conventional Commit parser filters files based on Librarian flow (#2433) ([6cb55d2](6cb55d2)) * Ensure detailed-tracing-attributes flag is fully propagated (#2438) ([a184f0d](a184f0d)) * relax footer regex to allow line broke footers to be properly recognized (#2388) ([dcbe063](dcbe063)) * release init provides read-only full repository (#2370) ([2e11004](2e11004)) * write the PR body on "commit but no push" (#2430) ([88698b4](88698b4)) * should not push to github when no push flag specified (#2405) ([2a49ae6](2a49ae6)) * only mount global files in configure command (#2377) ([1a2aaa0](1a2aaa0)) * `Map` field attribute in discovery (#2414) ([00c645f](00c645f)) * missing IDs in discovery doc fields (#2386) ([d579dd7](d579dd7)) </details>
Use the custom serialization / deserialization from `wkt::internal` instead of `DisplayFromStr`. We need to support deserializing from numbers as well as strings.
This change introduces a constant for the LIBRARIAN_GITHUB_TOKEN environment variable to improve maintainability and reduce duplication.
Fixes #2089.