fix: use empty line as a title-body separator#2345
Merged
JoeWang1127 merged 7 commits intomainfrom Sep 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
+ Coverage 84.15% 86.63% +2.48%
==========================================
Files 97 98 +1
Lines 9794 10583 +789
==========================================
+ Hits 8242 9169 +927
+ Misses 1206 1095 -111
+ Partials 346 319 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codyoss
reviewed
Sep 25, 2025
codyoss
approved these changes
Sep 25, 2025
zhumin8
pushed a commit
to zhumin8/librarian
that referenced
this pull request
Nov 17, 2025
Evidently they are legal in Protobuf, though no Google Cloud service uses them. ProtoJSON requires converting the `bool` to strings when used as map keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub will insert an empty line between commit title and body, we use this as an indicator of separating title and message.
Line breaks are not reliable because GitHub will wrap long lines with line breaks during squash and merge.
Created release pull request: #2346
Fixes #2234