Skip to content

test: add conditional GitHub integration tests#2210

Merged
chingor13 merged 3 commits intomainfrom
integration-tests
Sep 18, 2025
Merged

test: add conditional GitHub integration tests#2210
chingor13 merged 3 commits intomainfrom
integration-tests

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Sep 17, 2025

Towards #300

Usage:

TEST_GITHUB_TOKEN=<your-token> \
  TEST_GITHUB_REPOSITORY=<target-repo> \
  go test -v system_test.go

If you do not provide a TEST_GITHUB_TOKEN, none of the tests run. If you do not provide a TEST_GITHUB_REPOSITORY repository, then the pull request creation/edit tests do not run.

@chingor13 chingor13 requested a review from codyoss September 17, 2025 20:18
@chingor13 chingor13 changed the title test: add conditional GitHub test that runs if TEST_GITHUB_TOKEN is set test: add conditional GitHub integration tests Sep 17, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.92%. Comparing base (3cdc998) to head (a4f9613).
⚠️ Report is 43 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2210      +/-   ##
==========================================
+ Coverage   83.81%   83.92%   +0.10%     
==========================================
  Files          93       93              
  Lines        9357     9463     +106     
==========================================
+ Hits         7843     7942      +99     
- Misses       1168     1175       +7     
  Partials      346      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chingor13 chingor13 marked this pull request as ready for review September 17, 2025 20:40
@chingor13 chingor13 requested a review from a team as a code owner September 17, 2025 20:40
JoeWang1127
JoeWang1127 reviewed Sep 18, 2025
View reviewed changes
JoeWang1127
JoeWang1127 reviewed Sep 18, 2025
View reviewed changes
JoeWang1127
JoeWang1127 requested changes Sep 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we close the test pull request and remove the branch as a clean up of the tests?

@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Sep 18, 2025

Can we close the test pull request and remove the branch as a clean up of the tests?

Not unless we add more GitHub API calls that we want to maintain. Currently, running these tests is manual. If/when we want to programatically run these against a test repo, we can look into that.

@chingor13
Copy link
Copy Markdown
Contributor Author

chingor13 commented Sep 18, 2025

Can we close the test pull request and remove the branch as a clean up of the tests?

Will add new ClosePullRequest() and use in the cleanup in a follow up PR to avoid putting new features in this test PR

@chingor13 chingor13 merged commit 45db386 into main Sep 18, 2025
10 checks passed
@chingor13 chingor13 deleted the integration-tests branch September 18, 2025 18:52
@chingor13 chingor13 mentioned this pull request Sep 18, 2025
Merged
chingor13 added a commit that referenced this pull request Sep 18, 2025
@chingor13
feat: add DeleteBranch() and ClosePullRequest() (#2232)
234f2a2 
test: update system test to clean up branch and close the pull request.

Followup to #2210 that cleans up the branch we created and closes the
pull request.
Towards #300

Signed-off-by: Jeff Ching <[email protected]>
@chingor13 chingor13 added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2025
lqiu96 pushed a commit that referenced this pull request Sep 23, 2025
@chingor13 @lqiu96
test: add conditional GitHub integration tests (#2210)
c4b1354 
Towards #300 

Usage:

```bash
TEST_GITHUB_TOKEN=<your-token> \
  TEST_GITHUB_REPOSITORY=<target-repo> \
  go test -v system_test.go
```

If you do not provide a `TEST_GITHUB_TOKEN`, none of the tests run. If
you do not provide a `TEST_GITHUB_REPOSITORY` repository, then the pull
request creation/edit tests do not run.
lqiu96 added a commit that referenced this pull request Sep 23, 2025
@lqiu96
feat: add DeleteBranch() and ClosePullRequest() (#2232)
74f5645 
test: update system test to clean up branch and close the pull request.

Followup to #2210 that cleans up the branch we created and closes the
pull request.
Towards #300

Signed-off-by: Jeff Ching <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

@codyoss codyoss Awaiting requested review from codyoss

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chingor13 @JoeWang1127